Skip to content

buildPy cmake flag does not compile #120

@arsLibera

Description

@arsLibera

Description

I removed "main.h" since its a-typical and served no obvious purpose. I just found that buildPy required "main.h" but didn't realize that previously since it is not verified in the automated builds. I am suspicious that the buildPy was already defunct before I removed main.h, but that's besides the point.

If there are clients that use buildPy, we should collect their requirements, and refactor to a new header that satisfies those requirements. If there are no clients for it, I recommend removing it. Generally speaking, exposing the internal C++ headers makes the source more rigid, as this failure indicates. We should avoid exposing such details unless there is a use-case that cannot be met through a more standard input argument to the executable.

If we do need to fix it, I recommend we introduce a separate header, e.g., "cvOneDPythonInterface.hpp", rather than "main.h" that exposes limited functionality to the python interface. This would be more obvious than an exposed "main.h". That would help limit our exposure and give us a target for testing the SWIG interface.

@ktbolt @mrp089

Reproduction

Run cmake with buildPy command and then run the make

Expected behavior

Should build, but fails

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions