-
Notifications
You must be signed in to change notification settings - Fork 35
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Problem
Hello everyone,
I am a postdoctoral associate in @mrp089 's lab and I am planning to extend the calibrator functionality to the Chamber Sphere block. Specifically, I want to use inputs from 3D simulations of a ventricle (flow, pressure, etc.) to optimize the initial radius (radius0) and thickness (thick0) of the sphere.
While implementing this, I encountered the following issues:
- No error is raised if calibration is attempted on a block that does not have calibration implemented (i.e., the update_gradient function is missing);
- The current calibration code is not modular and is hardcoded specifically for the Blood Vessel block, making it difficult to extend to other block types like the Chamber Sphere.
Solution
- Modify calibrate.cpp so that an error is raised if calibration is attempted on a block without implemented calibration;
- Modify calibrate.cpp, ChamberSphere.cpp, ChamberSphere.h and LevenbergMarquardtOptimizer.cpp to allow calibration on the Chamber Sphere block and ensure the system can integrate calibration on additional blocks in the future.
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request