fix: 🐛 ScrollController is disposed when parent widget state changes (#289) (#333)

Author: lhengl

CHANGELOG.md

@@ -1,3 +1,8 @@
+## [2.4.2] (unreleased)
+
+* **Fix**: [289](https://github.com/SimformSolutionsPvtLtd/flutter_chatview/issues/289)
+  ScrollController is disposed when parent widget state changes
+
 ## [2.4.1]
 
 * **Important**: Updated minimum SDK version to `3.4.0`

example/lib/main.dart

@@ -35,37 +35,50 @@ class ChatScreen extends StatefulWidget {
 class _ChatScreenState extends State<ChatScreen> {
   AppTheme theme = LightTheme();
   bool isDarkTheme = false;
-  final _chatController = ChatController(
-    initialMessageList: Data.messageList,
-    scrollController: ScrollController(),
-    currentUser: const ChatUser(
-      id: '1',
-      name: 'Flutter',
-      profilePhoto: Data.profileImage,
-    ),
-    otherUsers: const [
-      ChatUser(
-        id: '2',
-        name: 'Simform',
-        profilePhoto: Data.profileImage,
-      ),
-      ChatUser(
-        id: '3',
-        name: 'Jhon',
-        profilePhoto: Data.profileImage,
-      ),
-      ChatUser(
-        id: '4',
-        name: 'Mike',
-        profilePhoto: Data.profileImage,
-      ),
-      ChatUser(
-        id: '5',
-        name: 'Rich',
+  late final ChatController _chatController;
+
+  @override
+  void initState() {
+    super.initState();
+    _chatController = ChatController(
+      initialMessageList: Data.messageList,
+      scrollController: ScrollController(),
+      currentUser: ChatUser(
+        id: '1',
+        name: 'Flutter',
         profilePhoto: Data.profileImage,
       ),
-    ],
-  );
+      otherUsers: [
+        ChatUser(
+          id: '2',
+          name: 'Simform',
+          profilePhoto: Data.profileImage,
+        ),
+        ChatUser(
+          id: '3',
+          name: 'Jhon',
+          profilePhoto: Data.profileImage,
+        ),
+        ChatUser(
+          id: '4',
+          name: 'Mike',
+          profilePhoto: Data.profileImage,
+        ),
+        ChatUser(
+          id: '5',
+          name: 'Rich',
+          profilePhoto: Data.profileImage,
+        ),
+      ],
+    );
+  }
+
+  @override
+  void dispose() {
+    // ChatController should be disposed to avoid memory leaks
+    _chatController.dispose();
+    super.dispose();
+  }
 
   void _showHideTypingIndicator() {
     _chatController.setTypingIndicator = !_chatController.showTypingIndicator;

lib/src/widgets/chat_list_widget.dart

@@ -245,8 +245,6 @@ class _ChatListWidgetState extends State<ChatListWidget> {
 
   @override
   void dispose() {
-    chatController.messageStreamController.close();
-    scrollController.dispose();
     _isNextPageLoading.dispose();
     super.dispose();
   }