Skip to content

Keep library version in library.json up to date #59

@robin-thoni

Description

@robin-thoni

Hi,

I just integrated your awesome library into ESPHome in my custom component repository. It works perfectly fine!

Image
[D][canbus_isotp:081]: received can iso-tp message std can_id=0x7e0 size=2
[D][canbus_isotp:075]: send standard id=0x7e8 size=2
[D][canbus:033]: send standard id=0x7e8 rtr=FALSE size=3
[D][canbus_isotp:075]: send standard id=0x7e8 size=2
[D][canbus:033]: send standard id=0x7e8 rtr=FALSE size=3

However, I just have one request: Could you please keep the library.json version up to date?
It's not a big deal, but ESPHome logs shows a random version in the logs:

Dependency Graph
|-- [...]
|-- isotp-c @ 0.0.0+v1.1.2.sha.083709f

This made me loose quite some time before realizing it was actually ok: The commit hash refers to v1.6.0, but the metadata is off.

Again, not a big deal, but it would be great to have things clean in the logs.

Thank you again for you awesome work!

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions