.

Author: SimonCropp

src/GraphQL.EntityFramework.Analyzers.Tests/FieldBuilderResolveAnalyzerTests.cs

@@ -2,6 +2,7 @@
 using GraphQL.Types;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
+using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.EntityFrameworkCore;
 
 namespace GraphQL.EntityFramework.Tests;
@@ -379,7 +380,7 @@ public ParentGraphType(IEfGraphQLService<TestDbContext> graphQlService) : base(g
         Assert.Equal("GQLEF002", diagnostics[0].Id);
     }
 
-    static async Task<IEnumerable<Diagnostic>> GetDiagnosticsAsync(string source)
+    static async Task<Diagnostic[]> GetDiagnosticsAsync(string source)
     {
         var syntaxTree = CSharpSyntaxTree.ParseText(source);
 
@@ -449,10 +450,8 @@ static async Task<IEnumerable<Diagnostic>> GetDiagnosticsAsync(string source)
         }
 
         // Filter to only GQLEF002 diagnostics
-        var gqlef002Diagnostics = allDiagnostics
+        return allDiagnostics
             .Where(d => d.Id == "GQLEF002")
             .ToArray();
-
-        return gqlef002Diagnostics;
     }
 }

src/GraphQL.EntityFramework.Analyzers.Tests/GraphQL.EntityFramework.Analyzers.Tests.csproj

@@ -14,6 +14,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <ProjectReference Include="..\GraphQL.EntityFramework.Analyzers\GraphQL.EntityFramework.Analyzers.csproj" />
     <ProjectReference Include="..\GraphQL.EntityFramework\GraphQL.EntityFramework.csproj" />
   </ItemGroup>
 </Project>

src/GraphQL.EntityFramework.Analyzers/GraphQL.EntityFramework.Analyzers.csproj

@@ -1,22 +1,18 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
-    <LangVersion>preview</LangVersion>
     <IsRoslynComponent>true</IsRoslynComponent>
     <DevelopmentDependency>true</DevelopmentDependency>
     <IncludeBuildOutput>false</IncludeBuildOutput>
     <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
-    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
     <Description>Roslyn analyzer for GraphQL.EntityFramework to detect problematic usage patterns</Description>
   </PropertyGroup>
 
   <ItemGroup>
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all" />
+    <PackageReference Include="ProjectDefaults" PrivateAssets="all" />
     <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" PrivateAssets="all" />
-  </ItemGroup>
-
-  <ItemGroup>
     <None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
   </ItemGroup>
 </Project>