fix(ci): preserve Robot test exit codes

Author: AnkushMalaker

.github/workflows/full-tests-with-api.yml

@@ -111,9 +111,9 @@ jobs:
         CLEANUP_CONTAINERS: "false"  # Don't cleanup in CI - handled by workflow
       run: |
         # Use the full test script (includes all tests with API keys)
-        ./run-robot-tests.sh
-        TEST_EXIT_CODE=$?
-        echo "test_exit_code=$TEST_EXIT_CODE" >> $GITHUB_ENV
+        TEST_EXIT_CODE=0
+        ./run-robot-tests.sh || TEST_EXIT_CODE=$?
+        echo "test_exit_code=$TEST_EXIT_CODE" >> "$GITHUB_ENV"
         exit 0  # Don't fail here, we'll fail at the end after uploading artifacts
 
     - name: Save service logs to files
@@ -255,8 +255,12 @@ jobs:
     - name: Fail workflow if tests failed
       if: always()
       run: |
-        if [ "${{ env.test_exit_code }}" != "0" ]; then
-          echo "❌ Tests failed with exit code ${{ env.test_exit_code }}"
+        TEST_EXIT_CODE="${{ env.test_exit_code }}"
+        if [ -z "$TEST_EXIT_CODE" ]; then
+          echo "❌ Test step did not record an exit code; check earlier setup/test steps"
+          exit 1
+        elif [ "$TEST_EXIT_CODE" != "0" ]; then
+          echo "❌ Tests failed with exit code $TEST_EXIT_CODE"
           exit 1
         else
           echo "✅ All tests passed"

.github/workflows/pr-tests-with-api.yml

@@ -105,9 +105,9 @@ jobs:
         CLEANUP_CONTAINERS: "false"  # Don't cleanup in CI - handled by workflow
       run: |
         # Use the full test script (includes all tests with API keys)
-        ./run-robot-tests.sh
-        TEST_EXIT_CODE=$?
-        echo "test_exit_code=$TEST_EXIT_CODE" >> $GITHUB_ENV
+        TEST_EXIT_CODE=0
+        ./run-robot-tests.sh || TEST_EXIT_CODE=$?
+        echo "test_exit_code=$TEST_EXIT_CODE" >> "$GITHUB_ENV"
         exit 0  # Don't fail here, we'll fail at the end after uploading artifacts
 
     - name: Save service logs to files
@@ -294,8 +294,12 @@ jobs:
     - name: Fail workflow if tests failed
       if: always()
       run: |
-        if [ "${{ env.test_exit_code }}" != "0" ]; then
-          echo "❌ Tests failed with exit code ${{ env.test_exit_code }}"
+        TEST_EXIT_CODE="${{ env.test_exit_code }}"
+        if [ -z "$TEST_EXIT_CODE" ]; then
+          echo "❌ Test step did not record an exit code; check earlier setup/test steps"
+          exit 1
+        elif [ "$TEST_EXIT_CODE" != "0" ]; then
+          echo "❌ Tests failed with exit code $TEST_EXIT_CODE"
           exit 1
         else
           echo "✅ All tests passed"

.github/workflows/robot-tests.yml

@@ -78,9 +78,9 @@ jobs:
       working-directory: tests
       run: |
         # Use Makefile target (starts containers with mock config, excludes api-keys/slow/sdk/gpu tests)
-        make test-no-api OUTPUTDIR=results-no-api
-        TEST_EXIT_CODE=$?
-        echo "test_exit_code=$TEST_EXIT_CODE" >> $GITHUB_ENV
+        TEST_EXIT_CODE=0
+        make test-no-api OUTPUTDIR=results-no-api || TEST_EXIT_CODE=$?
+        echo "test_exit_code=$TEST_EXIT_CODE" >> "$GITHUB_ENV"
         exit 0  # Don't fail here, we'll fail at the end after uploading artifacts
 
     - name: Save service logs to files
@@ -270,8 +270,12 @@ jobs:
     - name: Fail workflow if tests failed
       if: always()
       run: |
-        if [ "${{ env.test_exit_code }}" != "0" ]; then
-          echo "❌ Tests failed with exit code ${{ env.test_exit_code }}"
+        TEST_EXIT_CODE="${{ env.test_exit_code }}"
+        if [ -z "$TEST_EXIT_CODE" ]; then
+          echo "❌ Test step did not record an exit code; check earlier setup/test steps"
+          exit 1
+        elif [ "$TEST_EXIT_CODE" != "0" ]; then
+          echo "❌ Tests failed with exit code $TEST_EXIT_CODE"
           exit 1
         else
           echo "✅ All tests passed"