Skip to content

Commit f63ed9a

Browse files
SimplyLizclaude
andcommitted
ci: gofmt 9 source files and migrate scip-go install path
golangci-lint flagged gofmt drift across the v9.2.0 surface (impact types, MCP tool registration, symbol_exists, etc.). Apply gofmt to all 9 files. scip-go upstream renamed its module path from github.com/sourcegraph/scip-go to github.com/scip-code/scip-go. The release at v0.2.3 declares the new path in go.mod, which makes the old import error out with a version-constraints conflict. Update the install command in ci.yml, cov.yml, and ckb.yml; also update the human-readable hint printed when the indexer is missing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent e113870 commit f63ed9a

12 files changed

Lines changed: 27 additions & 29 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
cache: true
4848

4949
- name: Install scip-go
50-
run: go install github.com/sourcegraph/scip-go/cmd/scip-go@latest
50+
run: go install github.com/scip-code/scip-go/cmd/scip-go@latest
5151

5252
- name: Run tests
5353
run: go test -v -race ./...

.github/workflows/ckb.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ jobs:
8888
run: go build -ldflags="-s -w" -o ckb ./cmd/ckb
8989

9090
- name: Install SCIP indexer
91-
run: go install github.com/sourcegraph/scip-go/cmd/scip-go@latest
91+
run: go install github.com/scip-code/scip-go/cmd/scip-go@latest
9292

9393
# ───────────────────────────────────────────────────────────────────────
9494
# Cache & Index
@@ -114,7 +114,7 @@ jobs:
114114
echo "╔═══════════════════════════════════════════════════════════════════════════════╗"
115115
echo "║ INDEXER NOT FOUND ║"
116116
echo "╠═══════════════════════════════════════════════════════════════════════════════╣"
117-
echo "║ Go: go install github.com/sourcegraph/scip-go/cmd/scip-go@latest ║"
117+
echo "║ Go: go install github.com/scip-code/scip-go/cmd/scip-go@latest ║"
118118
echo "║ TypeScript: npm i -g @sourcegraph/scip-typescript ║"
119119
echo "║ Python: pip install scip-python ║"
120120
echo "║ Rust: cargo install scip ║"
@@ -989,7 +989,7 @@ jobs:
989989
run: go build -ldflags="-s -w" -o ckb ./cmd/ckb
990990

991991
- name: Install SCIP indexer
992-
run: go install github.com/sourcegraph/scip-go/cmd/scip-go@latest
992+
run: go install github.com/scip-code/scip-go/cmd/scip-go@latest
993993

994994
- name: Cache
995995
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5

.github/workflows/cov.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
cache: true
3232

3333
- name: Install scip-go
34-
run: go install github.com/sourcegraph/scip-go/cmd/scip-go@latest
34+
run: go install github.com/scip-code/scip-go/cmd/scip-go@latest
3535

3636
- name: Run tests with coverage
3737
run: |

cmd/ckb/review.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -222,11 +222,11 @@ func runReview(cmd *cobra.Command, args []string) {
222222
}
223223

224224
opts := query.ReviewPROptions{
225-
BaseBranch: reviewBaseBranch,
226-
HeadBranch: reviewHeadBranch,
227-
Policy: policy,
228-
Checks: reviewChecks,
229-
SkipChecks: reviewSkipChecks,
225+
BaseBranch: reviewBaseBranch,
226+
HeadBranch: reviewHeadBranch,
227+
Policy: policy,
228+
Checks: reviewChecks,
229+
SkipChecks: reviewSkipChecks,
230230
Staged: reviewStaged,
231231
Scope: scope,
232232
LLM: reviewLLM,

internal/cartographer/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ type BlastRadiusRelated struct {
519519
type RenderArchitectureResult struct {
520520
Diagram string `json:"diagram"`
521521
Truncated bool `json:"truncated"`
522-
Format string `json:"format"` // "mermaid" | "dot"
522+
Format string `json:"format"` // "mermaid" | "dot"
523523
NodeCount int `json:"nodeCount"`
524524
}
525525

internal/impact/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ type EnrichedCaller struct {
7171
SymbolURI string `json:"symbolUri,omitempty"`
7272
FileURI string `json:"fileUri"`
7373
Tier CouplingTier `json:"tier"`
74-
Confidence float64 `json:"confidence"` // 0.0–1.0
74+
Confidence float64 `json:"confidence"` // 0.0–1.0
7575
Similarity float32 `json:"similarity,omitempty"` // raw cosine similarity (semantic/both only)
7676
}
7777

internal/lip/blast_radius.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,4 +144,3 @@ func OutgoingEntryToExternal(entry *OutgoingImpactEntry) *impact.ExternalBlastRa
144144
}
145145
return ebr
146146
}
147-

internal/mcp/tools.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ func (s *MCPServer) GetToolDefinitions() []Tool {
159159
"description": "Bare symbol name to look up (e.g. \"saveReport\", \"ENV_PATH\")",
160160
},
161161
"kinds": map[string]interface{}{
162-
"type": "array",
163-
"items": map[string]interface{}{"type": "string"},
162+
"type": "array",
163+
"items": map[string]interface{}{"type": "string"},
164164
"description": "Optional kind filter (e.g. [\"method\", \"function\", \"class\", \"property\"])",
165165
},
166166
"scope": map[string]interface{}{

internal/query/impact.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,17 +118,17 @@ type BlastRadiusSummary struct {
118118
RiskLevel string `json:"riskLevel"` // "low", "medium", "high"
119119

120120
// LIP semantic enrichment (omitted when LIP is unavailable)
121-
StaticCallerCount int `json:"staticCallerCount,omitempty"`
122-
SemanticCallerCount int `json:"semanticCallerCount,omitempty"`
123-
ConfirmedCount int `json:"confirmedCount,omitempty"`
121+
StaticCallerCount int `json:"staticCallerCount,omitempty"`
122+
SemanticCallerCount int `json:"semanticCallerCount,omitempty"`
123+
ConfirmedCount int `json:"confirmedCount,omitempty"`
124124
SemanticCallers []SemanticCallerInfo `json:"semanticCallers,omitempty"`
125125
}
126126

127127
// SemanticCallerInfo is an embedding-discovered caller surfaced in the blast radius.
128128
type SemanticCallerInfo struct {
129129
SymbolURI string `json:"symbolUri,omitempty"`
130130
FileURI string `json:"fileUri"`
131-
Tier string `json:"tier"` // "semantic" or "both"
131+
Tier string `json:"tier"` // "semantic" or "both"
132132
Confidence float64 `json:"confidence"`
133133
Similarity float32 `json:"similarity,omitempty"`
134134
}

internal/query/impact_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ func ptrF64(v float64) *float64 { return &v }
1414

1515
func TestBridgeMultiplierFromGraph(t *testing.T) {
1616
tests := []struct {
17-
name string
18-
nodes []cartographer.GraphNode
19-
files []string
20-
wantMul float64
21-
wantFactor bool
22-
wantValue float64 // only checked when wantFactor=true
17+
name string
18+
nodes []cartographer.GraphNode
19+
files []string
20+
wantMul float64
21+
wantFactor bool
22+
wantValue float64 // only checked when wantFactor=true
2323
}{
2424
{
2525
name: "no nodes",

0 commit comments

Comments
 (0)