Skip to content
This repository was archived by the owner on Jun 7, 2026. It is now read-only.

Commit d5e4548

Browse files
committed
Fix git version detection in CI
1 parent a627f83 commit d5e4548

7 files changed

Lines changed: 31 additions & 8 deletions

File tree

.github/workflows/docker-publish.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,13 @@ jobs:
1919
id-token: write
2020
steps:
2121
- name: Checkout repository
22-
uses: actions/checkout@v4
22+
uses: actions/checkout@v5
23+
24+
- name: Git describe
25+
id: ghd
26+
uses: proudust/gh-describe@v2
2327
with:
24-
fetch-tags: true
28+
match: 'v*'
2529

2630
- name: Install cosign
2731
uses: sigstore/cosign-installer@59acb6260d9c0ba8f4a2f9d9b48431a222b68e20 #v3.5.0
@@ -49,6 +53,11 @@ jobs:
4953
uses: docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09 # v5.0.0
5054
with:
5155
context: .
56+
build-args: |
57+
"MANUAL_VERSIONING=true"
58+
"GIT_VERSION=${{ steps.ghd.outputs.describe }}"
59+
"GIT_HASH_FULL=${{ steps.ghd.outputs.sha }}"
60+
"GIT_HASH_SHORT=${{ steps.ghd.outputs.short-sha }}"
5261
push: true
5362
tags: ${{ steps.meta.outputs.tags }}
5463
labels: ${{ steps.meta.outputs.labels }}

Dockerfile

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
FROM debian:sid-slim AS build
22

3+
ARG MANUAL_VERSIONING=false
4+
ENV MANUAL_VERSIONING=${MANUAL_VERSIONING}
5+
ARG GIT_VERSION=0.0.0
6+
ENV GIT_VERSION=${GIT_VERSION}
7+
ARG GIT_HASH_FULL=unknown
8+
ENV GIT_HASH_FULL=${GIT_HASH_FULL}
9+
ARG GIT_HASH_SHORT=unknown
10+
ENV GIT_HASH_SHORT=${GIT_HASH_SHORT}
11+
312
WORKDIR /build
413

514
# Install dependencies
@@ -25,7 +34,6 @@ RUN git clone https://github.com/drogonframework/drogon && cd drogon && git subm
2534
# Build app
2635
WORKDIR /build/src
2736

28-
COPY $PWD/.git /build/src/.git
2937
COPY $PWD/builtin /build/src/builtin
3038
COPY $PWD/modules /build/src/modules
3139
COPY $PWD/src /build/src/src

modules/GitVersionDetect.cmake

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,13 @@ This will define the following variables:
3434
find_package(Git)
3535

3636
# Check if a git executable was found
37-
if(GIT_EXECUTABLE)
37+
if (DEFINED ENV{MANUAL_VERSIONING} AND "$ENV{MANUAL_VERSIONING}" STREQUAL "true")
38+
message("Using manual Git versioning")
39+
40+
string(REGEX REPLACE "^v" "" GITVERSIONDETECT_VERSION "$ENV{GIT_VERSION}")
41+
set(GIT_HASH_FULL "$ENV{GIT_HASH_FULL}")
42+
set(GIT_HASH_SHORT "$ENV{GIT_HASH_SHORT}")
43+
elseif(GIT_EXECUTABLE)
3844
# Generate a git-describe version string from Git repository tags
3945
execute_process(
4046
COMMAND ${GIT_EXECUTABLE} describe --tags --dirty --match "v*"

src/api/v1/game.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
#include <string>
44

5-
#include <content/recipe/recipe_parser.h>
5+
#include <service/content/recipe/recipe_parser.h>
66
#include <database/resolved_db.h>
77
#include <service/system/lang.h>
88

src/service/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ read_and_escape_schema("../../builtin/minecraft/recipe_type/stonecutting.json" S
77
read_and_escape_schema("../../builtin/minecraft/recipe_type/smithing_transform.json" SMITHING_TRANSFORM)
88

99
configure_file(content/recipe/builtin_recipe_type.h.in
10-
${CMAKE_CURRENT_BINARY_DIR}/content/recipe/builtin_recipe_type.h
10+
${CMAKE_CURRENT_BINARY_DIR}/service/content/recipe/builtin_recipe_type.h
1111
@ONLY
1212
)
1313

src/service/content/recipe/recipe_builtin.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#include "recipe_builtin.h"
22

3-
#include <content/builtin_recipe_type.h>
3+
#include <service/content/recipe/builtin_recipe_type.h>
44
#include <database/database.h>
55
#include <drogon/drogon.h>
66
#include <schemas/schemas.h>

src/service/resolved.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#include <filesystem>
1212
#include <unordered_map>
1313

14-
#include <content/recipe/recipe_resolver.h>
14+
#include <service/content/recipe/recipe_resolver.h>
1515
#include <fmt/args.h>
1616
#include <models/Item.h>
1717
#include <models/ProjectItem.h>

0 commit comments

Comments
 (0)