Skip to content

Conversation

@Sirivasv
Copy link
Owner

@Sirivasv Sirivasv commented Sep 13, 2025

Fixes #36

Copilot AI review requested due to automatic review settings September 13, 2025 12:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a placeholder implementation for shortest path calculation in the BMSSP (Bidirectional Multi-Source Shortest Path) class. The main changes include refactoring the shortest paths storage from an array to a Map and adding a basic calculateShortestPaths method.

  • Refactored shortest paths storage from array of tuples to Map for better performance
  • Extracted shortest paths initialization into a separate method
  • Added placeholder calculateShortestPaths method that sets start node distance to 0

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/bmssp.mjs Refactored shortest paths to use Map, extracted initialization method, added placeholder calculateShortestPaths
test/main.test.mjs Updated tests to work with Map instead of array, added test for calculateShortestPaths method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/bmssp.mjs:1

  • [nitpick] The test suite name 'BMSSP initialize calculateShortestPaths' is unclear. Consider renaming to 'BMSSP calculateShortestPaths' for better clarity.
class BMSSP {

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Sirivasv Sirivasv merged commit 978f989 into main Sep 13, 2025
5 checks passed
@Sirivasv Sirivasv deleted the feat/baseSSSP branch September 13, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the main calculate shortest paths function

2 participants