Cleanup in the test code

Removed the JS Tests

Author: stefannikolei

tests/PolygonClipper.Tests/GenericTestCases.cs

@@ -18,14 +18,13 @@ public class GenericTestCases
 {
     private readonly ITestOutputHelper _testOutputHelper;
 
-    public GenericTestCases(ITestOutputHelper  testOutputHelper)
+    public GenericTestCases(ITestOutputHelper testOutputHelper)
     {
         _testOutputHelper = testOutputHelper;
     }
-    public static IEnumerable<object[]> GetTestCasesJs()
-        => TestData.Generic.GetFileNames("js").Select(x => new object[] { x });
-    public static IEnumerable<object[]> GetTestCasesRust()
-        => TestData.Generic.GetFileNames("rust").Select(x => new object[] { x });
+
+    public static IEnumerable<object[]> GetTestCases()
+        => TestData.Generic.GetFileNames().Select(x => new object[] { x });
 
     [Fact]
     public Polygon Profile()
@@ -43,8 +42,8 @@ public Polygon Profile()
     }
 
     [Theory]
-    [MemberData(nameof(GetTestCasesRust))]
-    public void GenericTestCaseRust(string testCaseFile)
+    [MemberData(nameof(GetTestCases))]
+    public void GenericTestCase(string testCaseFile)
     {
         // Arrange
         FeatureCollection data = TestData.Generic.GetFeatureCollection(testCaseFile);
@@ -88,50 +87,6 @@ public void GenericTestCaseRust(string testCaseFile)
         }
     }
 
-    [Theory(Skip ="JS Tests are not relevant for now. Good when they pass but we focus on the Rust port")]
-    [MemberData(nameof(GetTestCasesJs))]
-    public void GenericTestCaseJs(string testCaseFile)
-    {
-        // Arrange
-        FeatureCollection data = TestData.Generic.GetFeatureCollection(testCaseFile);
-
-        Assert.True(data.Features.Count >= 2, "Test case file must contain at least two features.");
-
-        IGeometryObject subjectGeometry = data.Features[0].Geometry;
-        IGeometryObject clippingGeometry = data.Features[1].Geometry;
-
-        Polygon subject = ConvertToPolygon(subjectGeometry);
-        Polygon clipping = ConvertToPolygon(clippingGeometry);
-
-#pragma warning disable RCS1124 // Inline local variable
-        List<ExpectedResult> expectedResults = ExtractExpectedResults(data.Features.Skip(2).ToList(), data.Type);
-#pragma warning restore RCS1124 // Inline local variable
-
-        // ExpectedResult result = expectedResults[1];
-        // Polygon actual = result.Operation(subject, clipping);
-        // Assert.Equal(result.Coordinates.ContourCount, actual.ContourCount);
-
-        foreach (ExpectedResult result in expectedResults)
-        {
-            Polygon expected = result.Coordinates;
-            Polygon actual = result.Operation(subject, clipping);
-
-            Assert.Equal(expected.ContourCount, actual.ContourCount);
-            for (int i = 0; i < expected.ContourCount; i++)
-            {
-                // We don't test for holes here as the reference tests do not do so.
-                Assert.Equal(expected[i].VertexCount, actual[i].VertexCount);
-                for (int j = 0; j < expected[i].VertexCount; j++)
-                {
-                    Vertex expectedVertex = expected[i].GetVertex(j);
-                    Vertex actualVertex = actual[i].GetVertex(j);
-                    Assert.Equal(expectedVertex.X, actualVertex.X, 3);
-                    Assert.Equal(expectedVertex.Y, actualVertex.Y, 3);
-                }
-            }
-        }
-    }
-
     private static Polygon ConvertToPolygon(IGeometryObject geometry)
     {
         if (geometry is GeoPolygon geoJsonPolygon)

tests/PolygonClipper.Tests/TestData.cs

@@ -21,9 +21,9 @@ private static string GetGeoJsonPath(string fileName)
 
     public static class Generic
     {
-        public static IEnumerable<string> GetFileNames(string subFolder)
+        public static IEnumerable<string> GetFileNames()
         {
-            DirectoryInfo info = new(Path.Combine(TestEnvironment.GeoJsonTestDataFullPath, nameof(Generic), subFolder));
+            DirectoryInfo info = new(Path.Combine(TestEnvironment.GeoJsonTestDataFullPath, nameof(Generic)));
             foreach (FileInfo file in info.EnumerateFiles("*.geojson"))
             {
                 yield return file.Name;