Conflicts with other mods using /locraw

[robere2]

Looking at these lines:

Hytilities/src/main/java/club/sk1er/hytilities/util/locraw/LocrawUtil.java

Lines 80 to 82 in 8982ee7

	if (!this.playerSentCommand) {
	event.setCanceled(true);
	}

It appears that the /locraw message is always captured and cancelled unless the player sent it. This causes conflicts with other mods. that use /locraw if they do not set their priority higher. A higher priority would result in a never-ending war of who comes first.

The best solution to this in my opinion would be, instead of not cancelling when the message is player-sent, only cancel if the message is mod-sent.

[ImRodry]

It appears that the /locraw message is always captured and cancelled unless the player sent it.

The command is also canceled when the player runs it but this seems to be caused by something else in the code, not sure what though

[Sk1er]

Not that this is the only solution but I believe forge has a tag where you can have canceled events still flow into your event handler

[ImRodry]

Not that this is the only solution but I believe forge has a tag where you can have canceled events still flow into your event handler

This could fix other mods not being able to access the command but it still doesn't fix it being removed when the player executes it. I believe this is because the "listening" variable is set to true after 20 ticks and, therefore, playerSentCommand is set to false so it cancels the event either way. May be wrong but that's my best guess from looking at the code on the file bugfroggy linked

[DevBefell]

Not that this is the only solution but I believe forge has a tag where you can have canceled events still flow into your event handler

This could fix other mods not being able to access the command but it still doesn't fix it being removed when the player executes it. I believe this is because the "listening" variable is set to true after 20 ticks and, therefore, playerSentCommand is set to false so it cancels the event either way. May be wrong but that's my best guess from looking at the code on the file bugfroggy linked

I was the one that did the playerSendCommand, and it works, but because onMessageSend activates when the mod sends /locraw, sometimes it doesn't cancel the event, and I have yet to fix that correctly, which means that if other mods send the command, it should execute as a player had done it. I used it with DiscordRP and it doesn't seem to have any conflicts, I am not sure if DiscordRP set their priority higher, but it works as it should. And for the listening, I used it to try to make sure that it was the player sending it and not the mod sending it, which didn't work perfectly, not sure what was the original use of it as I am not the one that put that.

[vickensemerdjian]

Not that this is the only solution but I believe forge has a tag where you can have canceled events still flow into your event handler

This could fix other mods not being able to access the command but it still doesn't fix it being removed when the player executes it. I believe this is because the "listening" variable is set to true after 20 ticks and, therefore, playerSentCommand is set to false so it cancels the event either way. May be wrong but that's my best guess from looking at the code on the file bugfroggy linked

I was the one that did the playerSendCommand, and it works, but because onMessageSend activates when the mod sends /locraw, sometimes it doesn't cancel the event, and I have yet to fix that correctly, which means that if other mods send the command, it should execute as a player had done it. I used it with DiscordRP and it doesn't seem to have any conflicts, I am not sure if DiscordRP set their priority higher, but it works as it should. And for the listening, I used it to try to make sure that it was the player sending it and not the mod sending it, which didn't work perfectly, not sure what was the original use of it as I am not the one that put that.

Is it possible to have different parts of a mod (uncompiled) send different priorities to
forge (compiled)? So if a mod needed locraw it could have a higher priority; or the cancelation feature could have a low priority

[ImRodry]

That’s not needed, they just need to fix their checks which are already implemented

[vickensemerdjian]

That’s not needed, they just need to fix their checks which are already implemented

Why is it their problem?

[ImRodry]

Because the check they tried to implement is broken and cancels the command completely, even if it’s ran by the user