Skip to content

Commit 603742f

Browse files
committed
fix false adresses from full modpack
1 parent f439c6f commit 603742f

3 files changed

Lines changed: 11 additions & 9 deletions

File tree

loader/core/src/main/java/pl/skidam/automodpack_loader_core/client/ModpackUpdater.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,12 @@ public String getModpackName() {
4848
return serverModpackContent.modpackName;
4949
}
5050

51-
public void prepareUpdate(Jsons.ModpackContentFields modpackContent, InetSocketAddress address, Secrets.Secret secret) {
51+
public void prepareUpdate(Jsons.ModpackContentFields modpackContent, Jsons.ModpackAddresses modpackAddresses, Secrets.Secret secret) {
5252
this.serverModpackContent = modpackContent;
53-
this.modpackAddress = address;
53+
this.modpackAddresses = modpackAddresses;
54+
this.modpackAddress = modpackAddresses.hostAddress;
5455
this.modpackSecret = secret;
55-
this.modpackDir = ModpackUtils.getModpackPath(address, modpackContent.modpackName);
56-
this.modpackAddresses = new Jsons.ModpackAddresses(address, null); // falls nur hostAddress benötigt wird
56+
this.modpackDir = ModpackUtils.getModpackPath(modpackAddresses, modpackContent.modpackName);
5757

5858
// check out of selected Modpack
5959
SelectionManager.setSelectedPack(serverModpackContent.modpackName);
@@ -169,7 +169,7 @@ public void startLowUpdate() {}
169169
public void startServerUpdate() {}
170170
*/
171171
public void startUpdate() {
172-
modpackDir = ModpackUtils.getModpackPath(modpackAddress, serverModpackContent.modpackName);
172+
modpackDir = ModpackUtils.getModpackPath(modpackAddresses, serverModpackContent.modpackName);
173173
LOGGER.info("Using modpack directory: {}", modpackDir);
174174
if (modpackSecret == null) {
175175
LOGGER.error("Cannot update modpack, secret is null");

loader/core/src/main/java/pl/skidam/automodpack_loader_core/client/ModpackUtils.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -415,12 +415,13 @@ public static void addModpackToList(String modpackName, Jsons.ModpackAddresses m
415415
}
416416

417417
// Returns modpack name formatted for path or url if server doesn't provide modpack name
418-
public static Path getModpackPath(InetSocketAddress address, String modpackName) {
418+
public static Path getModpackPath(Jsons.ModpackAddresses address, String modpackName) {
419419
if (modpackName.equalsIgnoreCase("fullserver")) {
420420
return hostFullServerPackDir.resolve("fullserver");
421421
}
422422

423-
String strAddress = address.getHostString() + ":" + address.getPort();
423+
InetSocketAddress Address = address.hostAddress;
424+
String strAddress = Address.getHostString() + ":" + Address.getPort();
424425
String correctedName = strAddress;
425426

426427
if (FileInspection.isInValidFileName(strAddress)) {

src/main/java/pl/skidam/automodpack/networking/packet/DataC2SPacket.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,17 @@ public static CompletableFuture<PacketByteBuf> receive(MinecraftClient minecraft
6868
Boolean needsDisconnecting = null;
6969
PacketByteBuf response = new PacketByteBuf(Unpooled.buffer());
7070

71-
Path modpackDir = ModpackUtils.getModpackPath(modpackAddress, modpackName);
71+
7272
Jsons.ModpackAddresses modpackAddresses = new Jsons.ModpackAddresses(modpackAddress, serverAddress);
73+
Path modpackDir = ModpackUtils.getModpackPath(modpackAddresses, modpackName);
7374
var optionalServerModpackContent = ModpackUtils.requestServerModpackContent(modpackAddresses, secret, true);
7475

7576
if (optionalServerModpackContent.isPresent()) {
7677
boolean update = ModpackUtils.isUpdate(optionalServerModpackContent.get(), modpackDir);
7778

7879
if (update) {
7980
disconnectImmediately(handler);
80-
new ModpackUpdater().prepareUpdate(optionalServerModpackContent.get(), address, secret);
81+
new ModpackUpdater().prepareUpdate(optionalServerModpackContent.get(), modpackAddresses, secret);
8182
needsDisconnecting = true;
8283
} else {
8384
boolean selectedModpackChanged = ModpackUtils.selectModpack(modpackDir, modpackAddresses, Set.of());

0 commit comments

Comments
 (0)