Skip to content

Commit 93dfab2

Browse files
committed
docs: require approval before merge deploy
1 parent 2e4e652 commit 93dfab2

3 files changed

Lines changed: 16 additions & 3 deletions

File tree

AGENTS.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,10 @@ If sensitive data is committed, notify the maintainer immediately. Force-pushing
2121
- Any push to `master` deploys production
2222
- There is no staging environment in this repo
2323

24-
### Golden rule
24+
### Golden rules
2525

2626
> Never push directly to `master` without explicit maintainer approval.
27+
> Never merge a PR or run `make deploy` without explicit maintainer approval in the same conversation. A request to implement, fix, add, or prepare a change is approval to open a PR only; it is not approval to merge or deploy.
2728
2829
## Required workflow
2930

@@ -32,7 +33,8 @@ If sensitive data is committed, notify the maintainer immediately. Force-pushing
3233
3. Test locally
3334
4. Build before handing off for review
3435
5. Open a PR
35-
6. Merge to `master` only after approval
36+
6. Stop and wait for explicit maintainer approval before merging or deploying
37+
7. Merge to `master` or run `make deploy` only after that explicit approval
3638

3739
## Source of truth
3840

@@ -63,6 +65,13 @@ make deploy # production deploy: build docs/, commit them, and push to orig
6365
- Confirm changes belong in source files, not accidental edits to generated output only
6466
- Confirm the branch is intended for PR review, not direct production deploy
6567

68+
## Before you merge or deploy
69+
70+
- Confirm Jonathan/maintainer explicitly approved the merge or deploy in the current conversation
71+
- Do not infer merge/deploy approval from a request to implement, test, fix, add, or open a PR
72+
- If approval is unclear, ask once and wait
73+
- Rollbacks require explicit rollback authorization; rollback permission does not authorize unrelated merges/deploys
74+
6675
## Project guidance index
6776

6877
- `CONTRIBUTING.md` — human contributor workflow and PR checklist

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Before making changes, read:
1919
4. Run the smallest validation that matches your change.
2020
5. Open a pull request with a short summary and the validation you ran.
2121

22-
`master` deploys directly to production through GitHub Pages, so merges should be deliberate and reviewed.
22+
`master` deploys directly to production through GitHub Pages, so merges should be deliberate, reviewed, and explicitly approved. Implementation requests authorize preparing a branch/PR only; they do not authorize merging or deploying.
2323

2424
## Common commands
2525

@@ -43,6 +43,7 @@ Before requesting review, confirm:
4343
- Generated output changes are intentional.
4444
- Relevant validation passed, or any blocker is clearly documented in the PR.
4545
- The PR description explains what changed and how it was tested.
46+
- Maintainer approval to merge/deploy is explicit in the current conversation; if not, stop at the PR.
4647

4748
## Style expectations
4849

agent-docs/repository.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ Do not hand-edit `docs/` unless you are intentionally fixing generated output as
1919
- GitHub Pages serves the generated `docs/` directory
2020
- `docs/.nojekyll` is required for GitHub Pages to serve Next.js output correctly
2121
- `make deploy` is a production deploy command: it builds `docs/`, commits the generated output, and pushes to `origin master`
22+
- Do not merge to `master` or run `make deploy` without explicit maintainer approval in the same conversation
23+
- Treat implementation/fix requests as approval to prepare a PR only, not approval to ship production changes
2224

2325
## Key config files
2426

@@ -42,6 +44,7 @@ When changing configuration, keep docs concise and avoid duplicating file conten
4244
- Open a PR for review
4345
- Keep commits focused
4446
- Review generated output before shipping it
47+
- Stop at the PR until Jonathan/maintainer explicitly approves merge/deploy
4548

4649
## Public-repo security
4750

0 commit comments

Comments
 (0)