Skip to content

Commit 461cf06

Browse files
author
Lucas Hosseini
authored
[skiplang/skc] Re-enable clang inlining. (#744)
Inlining in clang was disabled because the inlining heuristics had changed in clang 15, leading to compile time blowups. The situation seems to have been fixed in clang 19 (possibly in an earlier version, we need to check with clang 16 once #736 is merged). Compile times for stage 2 skc: - Before this commit: clang 15, without inlining: 160.805s - After this commit: clang 15, with inlining: 600.047s clang 19, with inlining: 173.062s
2 parents db5c65d + de62b91 commit 461cf06

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

skiplang/compiler/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
OLEVEL ?= -O3
2-
CXXFLAGS ?= $(OLEVEL) -mllvm -inline-threshold=0 # -enable-new-pm=false
2+
CXXFLAGS ?= $(OLEVEL)
33
SKARGO_PROFILE ?= release
44
SKC_ARGS ?= --canonize-paths
55
SKARGO_ARGS ?= --profile $(SKARGO_PROFILE) $(foreach opt,$(SKC_ARGS),--skcopt $(opt))

skiplang/compiler/src/compile.sk

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,6 @@ fun link(
134134
Array[
135135
"clang++",
136136
`-O${config.optLevel}`,
137-
"-mllvm",
138-
"-inline-threshold=0",
139137
"-o",
140138
config.output,
141139
llFile,

0 commit comments

Comments
 (0)