Merge pull request #3518 from Skords-01/claude/youthful-gates-cktfvg

Author: Skords-01

packages/api-client/src/__tests__/contracts/_pact.ts

@@ -41,6 +41,22 @@ export const PACT_DIR = path.resolve(
  * gymnastics, and we don't need V4-only features (sync messages,
  * GraphQL) for HTTP REST contracts.
  */
+/**
+ * Vitest suite options for every pact contract `describe`.
+ *
+ * `retry: 2` absorbs a known pact-core FFI race: under loaded CI runners
+ * the mock server occasionally reports `missing-request` ("The following
+ * request was expected but not received") even though the client received
+ * the fully matched response and every assertion passed (the error is the
+ * `Promise.reject` branch of `executeTest`, which is only reachable when
+ * the test callback resolved). The race lives in the Rust mock-server
+ * match bookkeeping, not in our request shape, and surfaces in files with
+ * several sequential interactions (the PactV4 builder is torn down and
+ * re-created between `executeTest` calls). A real contract mismatch is
+ * deterministic and still fails all three attempts.
+ */
+export const CONTRACT_SUITE_OPTIONS = { retry: 2 } as const;
+
 export function createPact(): PactV4 {
   return new PactV4({
     consumer: CONSUMER,

packages/api-client/src/__tests__/contracts/barcode.contract.test.ts

@@ -19,9 +19,9 @@ import type { PactV4 } from "@pact-foundation/pact";
 
 import { createHttpClient } from "../../httpClient";
 import { createBarcodeEndpoints } from "../../endpoints/barcode";
-import { createPact } from "./_pact";
+import { CONTRACT_SUITE_OPTIONS, createPact } from "./_pact";
 
-describe("contract @ GET /api/v1/barcode", () => {
+describe("contract @ GET /api/v1/barcode", CONTRACT_SUITE_OPTIONS, () => {
   let pact: PactV4;
   beforeAll(() => {
     pact = createPact();

packages/api-client/src/__tests__/contracts/chat.contract.test.ts

@@ -17,52 +17,56 @@ import type { PactV4 } from "@pact-foundation/pact";
 
 import { createHttpClient } from "../../httpClient";
 import { createChatEndpoints } from "../../endpoints/chat";
-import { createPact } from "./_pact";
+import { CONTRACT_SUITE_OPTIONS, createPact } from "./_pact";
 
-describe("contract @ POST /api/v1/chat (non-streaming)", () => {
-  let pact: PactV4;
-  beforeAll(() => {
-    pact = createPact();
-  });
-  afterAll(() => {});
+describe(
+  "contract @ POST /api/v1/chat (non-streaming)",
+  CONTRACT_SUITE_OPTIONS,
+  () => {
+    let pact: PactV4;
+    beforeAll(() => {
+      pact = createPact();
+    });
+    afterAll(() => {});
 
-  it("returns assistant text for a simple user prompt (hub persona)", async () => {
-    await pact
-      .addInteraction()
-      .given(
-        "authenticated user-pact-001 with a clean conversation; Anthropic stub returns fixed assistant text",
-      )
-      .uponReceiving(
-        "a POST /api/v1/chat request without tool-calls (non-streaming)",
-      )
-      .withRequest("POST", "/api/v1/chat", (req) => {
-        req.headers({
-          accept: "application/json",
-          "content-type": "application/json",
+    it("returns assistant text for a simple user prompt (hub persona)", async () => {
+      await pact
+        .addInteraction()
+        .given(
+          "authenticated user-pact-001 with a clean conversation; Anthropic stub returns fixed assistant text",
+        )
+        .uponReceiving(
+          "a POST /api/v1/chat request without tool-calls (non-streaming)",
+        )
+        .withRequest("POST", "/api/v1/chat", (req) => {
+          req.headers({
+            accept: "application/json",
+            "content-type": "application/json",
+          });
+          req.jsonBody({
+            context: "hub",
+            messages: [{ role: "user", content: "Привіт, як справи?" }],
+            stream: false,
+          });
+        })
+        .willRespondWith(200, (res) => {
+          res.headers({ "content-type": "application/json" });
+          res.jsonBody({
+            text: "Все ок, що треба зробити?",
+          });
+        })
+        .executeTest(async (mockServer) => {
+          const http = createHttpClient({ baseUrl: mockServer.url });
+          const chat = createChatEndpoints(http);
+          const out = await chat.send({
+            context: "hub",
+            messages: [{ role: "user", content: "Привіт, як справи?" }],
+            stream: false,
+          });
+          expect(out.text).toBe("Все ок, що треба зробити?");
+          expect(out.tool_calls).toBeUndefined();
+          expect(out.error).toBeUndefined();
         });
-        req.jsonBody({
-          context: "hub",
-          messages: [{ role: "user", content: "Привіт, як справи?" }],
-          stream: false,
-        });
-      })
-      .willRespondWith(200, (res) => {
-        res.headers({ "content-type": "application/json" });
-        res.jsonBody({
-          text: "Все ок, що треба зробити?",
-        });
-      })
-      .executeTest(async (mockServer) => {
-        const http = createHttpClient({ baseUrl: mockServer.url });
-        const chat = createChatEndpoints(http);
-        const out = await chat.send({
-          context: "hub",
-          messages: [{ role: "user", content: "Привіт, як справи?" }],
-          stream: false,
-        });
-        expect(out.text).toBe("Все ок, що треба зробити?");
-        expect(out.tool_calls).toBeUndefined();
-        expect(out.error).toBeUndefined();
-      });
-  });
-});
+    });
+  },
+);

packages/api-client/src/__tests__/contracts/coach-memory.contract.test.ts

@@ -17,9 +17,9 @@ import type { PactV4 } from "@pact-foundation/pact";
 
 import { createHttpClient } from "../../httpClient";
 import { createCoachEndpoints } from "../../endpoints/coach";
-import { createPact } from "./_pact";
+import { CONTRACT_SUITE_OPTIONS, createPact } from "./_pact";
 
-describe("contract @ GET /api/v1/coach/memory", () => {
+describe("contract @ GET /api/v1/coach/memory", CONTRACT_SUITE_OPTIONS, () => {
   let pact: PactV4;
   beforeAll(() => {
     pact = createPact();

packages/api-client/src/__tests__/contracts/food-search.contract.test.ts

@@ -20,9 +20,9 @@ import type { PactV4 } from "@pact-foundation/pact";
 
 import { createHttpClient } from "../../httpClient";
 import { createFoodSearchEndpoints } from "../../endpoints/foodSearch";
-import { createPact } from "./_pact";
+import { CONTRACT_SUITE_OPTIONS, createPact } from "./_pact";
 
-describe("contract @ GET /api/food-search", () => {
+describe("contract @ GET /api/food-search", CONTRACT_SUITE_OPTIONS, () => {
   let pact: PactV4;
   beforeAll(() => {
     pact = createPact();

packages/api-client/src/__tests__/contracts/me.contract.test.ts

@@ -14,9 +14,9 @@ import type { PactV4 } from "@pact-foundation/pact";
 
 import { createHttpClient } from "../../httpClient";
 import { createMeEndpoints } from "../../endpoints/me";
-import { createPact } from "./_pact";
+import { CONTRACT_SUITE_OPTIONS, createPact } from "./_pact";
 
-describe("contract @ GET /api/v1/me", () => {
+describe("contract @ GET /api/v1/me", CONTRACT_SUITE_OPTIONS, () => {
   let pact: PactV4;
   beforeAll(() => {
     pact = createPact();

packages/api-client/src/__tests__/contracts/mono-syncState.contract.test.ts

@@ -15,44 +15,48 @@ import type { PactV4 } from "@pact-foundation/pact";
 
 import { createHttpClient } from "../../httpClient";
 import { createMonoWebhookEndpoints } from "../../endpoints/mono";
-import { createPact } from "./_pact";
+import { CONTRACT_SUITE_OPTIONS, createPact } from "./_pact";
 
-describe("contract @ GET /api/v1/mono/sync-state", () => {
-  let pact: PactV4;
-  beforeAll(() => {
-    pact = createPact();
-  });
-  afterAll(() => {});
+describe(
+  "contract @ GET /api/v1/mono/sync-state",
+  CONTRACT_SUITE_OPTIONS,
+  () => {
+    let pact: PactV4;
+    beforeAll(() => {
+      pact = createPact();
+    });
+    afterAll(() => {});
 
-  it("returns MonoSyncState for a connected, active webhook (finyk persona)", async () => {
-    await pact
-      .addInteraction()
-      .given(
-        "an authenticated session for user-pact-001 with an active Monobank webhook (2 accounts)",
-      )
-      .uponReceiving("a GET /api/v1/mono/sync-state request")
-      .withRequest("GET", "/api/v1/mono/sync-state", (req) => {
-        req.headers({ accept: "application/json" });
-      })
-      .willRespondWith(200, (res) => {
-        res.headers({ "content-type": "application/json" });
-        res.jsonBody({
-          status: "active",
-          webhookActive: true,
-          lastEventAt: "2026-05-13T08:30:00.000Z",
-          lastBackfillAt: "2026-05-12T22:00:00.000Z",
-          accountsCount: 2,
+    it("returns MonoSyncState for a connected, active webhook (finyk persona)", async () => {
+      await pact
+        .addInteraction()
+        .given(
+          "an authenticated session for user-pact-001 with an active Monobank webhook (2 accounts)",
+        )
+        .uponReceiving("a GET /api/v1/mono/sync-state request")
+        .withRequest("GET", "/api/v1/mono/sync-state", (req) => {
+          req.headers({ accept: "application/json" });
+        })
+        .willRespondWith(200, (res) => {
+          res.headers({ "content-type": "application/json" });
+          res.jsonBody({
+            status: "active",
+            webhookActive: true,
+            lastEventAt: "2026-05-13T08:30:00.000Z",
+            lastBackfillAt: "2026-05-12T22:00:00.000Z",
+            accountsCount: 2,
+          });
+        })
+        .executeTest(async (mockServer) => {
+          const http = createHttpClient({ baseUrl: mockServer.url });
+          const mono = createMonoWebhookEndpoints(http);
+          const state = await mono.syncState();
+          expect(state.status).toBe("active");
+          expect(state.webhookActive).toBe(true);
+          expect(state.lastEventAt).toBe("2026-05-13T08:30:00.000Z");
+          expect(state.lastBackfillAt).toBe("2026-05-12T22:00:00.000Z");
+          expect(state.accountsCount).toBe(2);
         });
-      })
-      .executeTest(async (mockServer) => {
-        const http = createHttpClient({ baseUrl: mockServer.url });
-        const mono = createMonoWebhookEndpoints(http);
-        const state = await mono.syncState();
-        expect(state.status).toBe("active");
-        expect(state.webhookActive).toBe(true);
-        expect(state.lastEventAt).toBe("2026-05-13T08:30:00.000Z");
-        expect(state.lastBackfillAt).toBe("2026-05-12T22:00:00.000Z");
-        expect(state.accountsCount).toBe(2);
-      });
-  });
-});
+    });
+  },
+);