DON-1396 Use tokens for size

henrik-sky · henrik-sky · commit d8cf33b221b3 · 2025-04-29T10:56:54.000+01:00
diff --git a/app/src/main/java/net/skyscanner/backpack/demo/compose/CalendarStory.kt b/app/src/main/java/net/skyscanner/backpack/demo/compose/CalendarStory.kt
@@ -110,7 +110,7 @@ fun CalendarLoading(modifier: Modifier = Modifier) {
     var type by remember { mutableStateOf(CalendarStoryType.Loading) }
     CalendarDemo(type, modifier)
     LaunchedEffect(Unit) {
-        delay(10)
+        delay(1000)
         type = CalendarStoryType.WithIconAsLabels
     }
 }
diff --git a/backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/calendar/internal/BpkCalendarDayCell.kt b/backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/calendar/internal/BpkCalendarDayCell.kt
@@ -198,11 +198,13 @@ internal fun BpkCalendarDayCell(
                             BpkShimmerOverlay(
                                 shimmerSize = BpkShimmerSize.Small,
                             ) {
+                                val width = BpkSpacing.Lg + BpkSpacing.Sm
+                                val height = BpkSpacing.Md + BpkSpacing.Sm
                                 BpkHeadlineSkeleton(
                                     skeletonHeightSize = BpkSkeletonHeightSizeType.Custom,
                                     modifier = Modifier
                                         .semantics { contentDescription = label.contentDescription }
-                                        .size(width = 28.dp, height = 12.dp)
+                                        .size(width = width, height = height)
                                         .align(Alignment.Center),
                                 )
                             }
diff --git a/backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/skeleton/BpkSkeleton.kt b/backpack-compose/src/main/kotlin/net/skyscanner/backpack/compose/skeleton/BpkSkeleton.kt
@@ -106,7 +106,7 @@ enum class BpkShimmerSize(
     val durationMillis: Int,
     val delayMillis: Int,
 ) {
-    Large(1000, 200), Small(300, 0)
+    Large(1000, 200), Small(300, 10)
 }
 
 private fun Modifier.enhanceHeadlineHeight(skeletonHeightSize: BpkSkeletonHeightSizeType): Modifier {

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ fun CalendarLoading(modifier: Modifier = Modifier) {`
`110`	`110`	`var type by remember { mutableStateOf(CalendarStoryType.Loading) }`
`111`	`111`	`CalendarDemo(type, modifier)`
`112`	`112`	`LaunchedEffect(Unit) {`
`113`		`- delay(10)`
	`113`	`+ delay(1000)`
`114`	`114`	`type = CalendarStoryType.WithIconAsLabels`
`115`	`115`	`}`
`116`	`116`	`}`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ enum class BpkShimmerSize(`
`106`	`106`	`val durationMillis: Int,`
`107`	`107`	`val delayMillis: Int,`
`108`	`108`	`) {`
`109`		`- Large(1000, 200), Small(300, 0)`
	`109`	`+ Large(1000, 200), Small(300, 10)`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`private fun Modifier.enhanceHeadlineHeight(skeletonHeightSize: BpkSkeletonHeightSizeType): Modifier {`