start(plugin) does not work

[spogdev]

Laser.GuardianLaser laser = new Laser.GuardianLaser(player.getLocation(), current, tickDuration, -1); laser.start(plugin);

for some reason start() does not actually start it as it never appears, when I try to run stop on the laser later it throws an error

i dont know if im being stupid or this is a bug but it seems like a bug to me

[SkytAsul]

What is your server version?
What is the error than is thrown when you stop the laser?

[spogdev]

im running 1.21.8 paper

'[19:13:41 WARN]: [CryoV3] Task #44 for CryoCoreV3 v1.0.0 generated an exception
java.lang.IllegalStateException: Task not started
at cryov3-1.0.jar/network.cryo.libraries.guardianbeam.Laser.stop(Laser.java:148) ~[cryov3-1.0.jar:?]
at cryov3-1.0.jar/network.cryo.cryov3.tokens.abilities.Ability$11.run(Ability.java:895) ~[cryov3-1.0.jar:?]
at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:78) ~[paper-1.21.8.jar:1.21.8-60-29c8822]
at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:474) ~[paper-1.21.8.jar:1.21.8-60-29c8822]
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1663) ~[paper-1.21.8.jar:1.21.8-60-29c8822]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1531) ~[paper-1.21.8.jar:1.21.8-60-29c8822]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1253) ~[paper-1.21.8.jar:1.21.8-60-29c8822]
at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:310) ~[paper-1.21.8.jar:1.21.8-60-29c8822]
at java.base/java.lang.Thread.run(Thread.java:1570) ~[?:?]'

[spogdev]

public static void activateGuardian(Player player) {
        CryoPlugin plugin = CryoPlugin.getInstance();
        PlayerDataCache cache = CryoPlugin.getPlayerDataCache();

        int duration = plugin.getConfig().getInt("tokens.GUARDIAN.abilities.active.duration");
        int tickDuration = duration * 20;

        Map<Player, Laser.GuardianLaser> affected = new HashMap<>();
        for (Player current : plugin.getPlayersInRadius(player.getLocation(), 20)) {
            if (!plugin.isTrusted(player, current)) {
                try {
                    Laser.GuardianLaser laser = new Laser.GuardianLaser(player.getLocation(), current, tickDuration, -1);
                    laser.start(plugin);
                    affected.putIfAbsent(current, laser);
                    current.addPotionEffect(new PotionEffect(PotionEffectType.SLOWNESS, tickDuration, 1));
                } catch (Exception e) {
                    e.printStackTrace();
                }
            }
        }

        player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, tickDuration, affected.size() - 1));

        new BukkitRunnable() {
            @Override
            public void run() {
                if (!(new AbilityManager(plugin).isAbilityActive(player, TokenType.GUARDIAN))) {
                    for (Player current : affected.keySet()) {
                        current.damage(40);
                        affected.get(current).stop();
                    }
                    cancel();
                } else {
                    for (Player current : affected.keySet()) {
                        try {
                            affected.get(current).moveStart(current.getLocation());
                        } catch (ReflectiveOperationException e) {
                            throw new RuntimeException(e);
                        }
                    }
                }
            }
        }.runTaskTimer(plugin, 0L, 1L);
    }

Also this is the full code I was running

[SkytAsul]

From what I see, it seems like you are continuously moving the starting point of the laser to the player's location, while the end of the laser is attached to the player. This is pretty weird.
Also, if you are getting a "Task not started" error, it means that you are calling the "stop" method multiple times. Your code is probably wrong. Try to put some logs when you call "start" and "stop" to see what's going on.

[spogdev]

Hows it weird?

What im trying to do is make it so the laser links every entity in the radius then updates the laser so it is connected to the player too

[spogdev]

even after that in theory the two lines i sent before should work though no?

[SkytAsul]

Hows it weird?

Well, both the start and the end are attached to the player (current). How do you even want to view a laser which has the same start and end location?

even after that in theory the two lines i sent before should work though no?

Yes, except if current and player are the same entities.

[spogdev]

I just saw this message and was confused because the start is supposed to be at the player and the end at every entity attatched to the start player. I realised my loop set it to the current player not player. I changed it.

It still doesn't work even after that change.

I could still be being stupid, I put it into ChatGPT for a sanity check and it said there was likely an error with the library and not my code because the logic seems fine.

public static void activateGuardian(Player player) {
        CryoPlugin plugin = CryoPlugin.getInstance();
        PlayerDataCache cache = CryoPlugin.getPlayerDataCache();

        int duration = plugin.getConfig().getInt("tokens.GUARDIAN.abilities.active.duration");
        int tickDuration = duration * 20;

        Map<Player, Laser.GuardianLaser> affected = new HashMap<>();
        for (Player current : plugin.getPlayersInRadius(player.getLocation(), 20)) {
            if (!plugin.isTrusted(player, current)) {
                try {
                    Laser.GuardianLaser laser = new Laser.GuardianLaser(player.getLocation(), current, tickDuration, 200);
                    laser.start(plugin);
                    affected.putIfAbsent(current, laser);
                    current.addPotionEffect(new PotionEffect(PotionEffectType.SLOWNESS, tickDuration, 1));
                } catch (Exception e) {
                    throw new RuntimeException(e);
                }
            }
        }

        player.addPotionEffect(new PotionEffect(PotionEffectType.REGENERATION, tickDuration, affected.size() - 1));

        new BukkitRunnable() {
            @Override
            public void run() {
                if (!(new AbilityManager(plugin).isAbilityActive(player, TokenType.GUARDIAN))) {
                    cancel();
                } else {
                    for (Player current : affected.keySet()) {
                        try {
                            affected.get(current).moveStart(player.getLocation());
                        } catch (ReflectiveOperationException e) {
                            throw new RuntimeException(e);
                        }
                    }
                }
            }
        }.runTaskTimer(plugin, 0L, 10L);
    }

[SkytAsul]

Yeah your code looks right. Are you using the latest version of GuardianBeam? Also, are you using a modded client? Please try a vanilla one. And I mean full vanilla: no optimization mod, no shaders, etc.

[spogdev]

I tried using vanilla actually because I thought I had a mod or something so I looked through my ALTs pov which was running full minecraft launcher vanilla. Im using the latest version, 4.5.0.