Merge pull request #915 from SlideRuleEarth/carlos-dev4

in version v2.11.0 the records view can hang #913

Author: cugarteblair

web-client/src/db/SlideRuleDb.ts

@@ -1066,7 +1066,7 @@ export class SlideRuleDexie extends Dexie {
             reqId: req_id,
             error: parseError instanceof Error ? parseError.message : String(parseError)
           })
-          return {} as SrRegion
+          return []
         }
 
         if (svrParmsUsed.server) {
@@ -1084,7 +1084,7 @@ export class SlideRuleDexie extends Dexie {
                 status: request?.status
               })
             }
-            return {} as SrRegion
+            return []
           }
         } else if (svrParmsUsed.poly) {
           return svrParmsUsed.poly //atl24x with new server format
@@ -1094,15 +1094,15 @@ export class SlideRuleDexie extends Dexie {
           } else {
             logger.warn('No svr_parms.poly found', { reqId: req_id, status: request?.status })
           }
-          return {} as SrRegion
+          return []
         }
       } else {
         if (isSuccess) {
           logger.error('No svr_parms found', { reqId: req_id, status: request?.status })
         } else {
           logger.warn('No svr_parms found', { reqId: req_id, status: request?.status })
         }
-        return {} as SrRegion
+        return []
       }
     } catch (error) {
       const request = await this.requests.get(req_id)

web-client/src/utils/SrDuckDbUtils.ts

@@ -922,7 +922,6 @@ export const duckDbReadAndUpdateElevationData = async (
         updateDeckLayerWithObject(
           layerName,
           rows,
-          summary.extHMean,
           height_fieldname,
           positions,
           projName,
@@ -1129,7 +1128,6 @@ export const duckDbReadAndUpdateSelectedLayer = async (req_id: number, layerName
         updateDeckLayerWithObject(
           layerName,
           rowChunks,
-          summary.extHMean,
           height_fieldname,
           positions,
           projName,

web-client/src/utils/SrMapUtils.ts

@@ -13,7 +13,6 @@ import Graticule from 'ol/layer/Graticule.js'
 import type OLMap from 'ol/Map.js'
 import { unByKey } from 'ol/Observable'
 import type { EventsKey } from 'ol/events'
-import type { ExtHMean } from '@/workers/workerUtils'
 import { Style, Icon, Fill, Stroke, Circle as CircleStyle } from 'ol/style'
 import { Text as TextStyle } from 'ol/style'
 import { getSpotNumber, getGtsForSpotsAndScOrients } from '@/utils/spotUtils'
@@ -872,7 +871,6 @@ export function createDeckLayer(
 export function updateDeckLayerWithObject(
   name: string,
   elevationData: ElevationDataItem[],
-  extHMean: ExtHMean,
   heightFieldName: string,
   positions: SrPosition[],
   _projName: string,

web-client/tests/unit/SlideRuleDb.spec.ts

@@ -122,35 +122,52 @@ describe('SlideRuleDb.getSvrReqPoly', () => {
       expect(result).toEqual(samplePoly)
     })
 
-    it('should return empty object when svr_parms is empty', async () => {
+    it('should return empty array when svr_parms is empty', async () => {
       mockRequest.svr_parms = undefined
 
       vi.spyOn(db.requests, 'get').mockResolvedValue(mockRequest)
 
       const result = await db.getSvrReqPoly(123)
 
-      expect(result).toEqual({})
+      expect(result).toEqual([])
+      expect(Array.isArray(result)).toBe(true)
     })
 
-    it('should return empty object when svr_parms has no poly', async () => {
+    it('should return empty array when svr_parms has no poly', async () => {
       mockRequest.svr_parms = { someOtherField: 'value' } as any
 
       vi.spyOn(db.requests, 'get').mockResolvedValue(mockRequest)
 
       const result = await db.getSvrReqPoly(123)
 
-      expect(result).toEqual({})
+      expect(result).toEqual([])
+      expect(Array.isArray(result)).toBe(true)
     })
 
-    it('should return empty object for invalid JSON string', async () => {
+    it('should return empty array for invalid JSON string', async () => {
       mockRequest.svr_parms = 'not valid json{' as any
 
       vi.spyOn(db.requests, 'get').mockResolvedValue(mockRequest)
 
       const result = await db.getSvrReqPoly(123)
 
-      // Should return empty object instead of throwing
-      expect(result).toEqual({})
+      // Should return empty array instead of throwing
+      expect(result).toEqual([])
+      expect(Array.isArray(result)).toBe(true)
+    })
+
+    it('should return a value that supports .map() even when empty', async () => {
+      // This is a regression test for the bug where {} was returned instead of []
+      // which caused "t.map is not a function" errors when code tried to use .map()
+      mockRequest.svr_parms = undefined
+
+      vi.spyOn(db.requests, 'get').mockResolvedValue(mockRequest)
+
+      const result = await db.getSvrReqPoly(123)
+
+      // This is the key test - .map() should work without crashing
+      expect(() => result.map((p) => [p.lon, p.lat])).not.toThrow()
+      expect(result.map((p) => [p.lon, p.lat])).toEqual([])
     })
 
     it('should handle nested server.rqst.parms structure with string input', async () => {