fix(UnbreakableRune): fix runes not work on items without ItemMeta, resolve #32

Author: ybw0014

pom.xml

@@ -14,9 +14,10 @@
     </properties>
 
     <repositories>
+
         <repository>
-            <id>paper-repo</id>
-            <url>https://repo.destroystokyo.com/repository/maven-public/</url>
+            <id>papermc</id>
+            <url>https://repo.papermc.io/repository/maven-public/</url>
         </repository>
 
         <repository>
@@ -108,16 +109,16 @@
 
     <dependencies>
         <dependency>
-            <groupId>org.spigotmc</groupId>
-            <artifactId>spigot-api</artifactId>
-            <version>1.19.4-R0.1-SNAPSHOT</version>
+            <groupId>io.papermc.paper</groupId>
+            <artifactId>paper-api</artifactId>
+            <version>1.20.4-R0.1-SNAPSHOT</version>
             <scope>provided</scope>
         </dependency>
 
         <dependency>
-            <groupId>com.github.StarWishsama</groupId>
+            <groupId>com.github.SlimefunGuguProject</groupId>
             <artifactId>Slimefun4</artifactId>
-            <version>2024.3</version>
+            <version>2025.1</version>
             <scope>provided</scope>
         </dependency>
 

src/main/java/me/gallowsdove/foxymachines/implementation/consumables/UnbreakableRune.java

@@ -67,7 +67,7 @@ public ItemDropHandler getItemHandler() {
         return (e, p, item) -> {
             if (isItem(item.getItemStack())) {
 
-                if (!SlimefunUtils.canPlayerUseItem(p, Items.UNBREAKABLE_RUNE , true)) {
+                if (!SlimefunUtils.canPlayerUseItem(p, Items.UNBREAKABLE_RUNE, true)) {
                     return true;
                 }
 
@@ -90,21 +90,19 @@ private void activate(@Nonnull Player p, @Nonnull Item rune) {
 
         if (optional.isPresent()) {
             Item item = (Item) optional.get();
-            ItemStack itemStack = item.getItemStack();
+            ItemStack itemStack = item.getItemStack().clone();
 
             if (itemStack.getAmount() == 1) {
                 l.getWorld().strikeLightningEffect(l);
 
                 Scheduler.run(10, () -> {
-                    if (rune.isValid() && item.isValid() && itemStack.getAmount() == 1) {
-
+                    if (rune.isValid() && item.isValid() && itemStack.getAmount() == 1 && setUnbreakable(itemStack)) {
                         l.getWorld().createExplosion(l, 0);
                         l.getWorld().playSound(l, Sound.ENTITY_GENERIC_EXPLODE, 0.3F, 1);
 
                         item.remove();
                         rune.remove();
 
-                        setUnbreakable(itemStack);
                         l.getWorld().dropItemNaturally(l, itemStack);
 
                         p.sendMessage(ChatColor.LIGHT_PURPLE + "你的物品已经不可破坏了");
@@ -127,16 +125,20 @@ private boolean findCompatibleItem(Player player, Entity entity) {
         return false;
     }
 
-    public static void setUnbreakable(@Nullable ItemStack item) {
-        if (item != null && item.getType() != Material.AIR) {
-
-            if (!isUnbreakable(item) && item.hasItemMeta()) {
-                ItemMeta meta = item.getItemMeta();
+    public static boolean setUnbreakable(@Nullable ItemStack item) {
+        if (item == null || item.getType().isAir() || isUnbreakable(item)) {
+            return false;
+        }
 
-                meta.setUnbreakable(true);
-                item.setItemMeta(meta);
-            }
+        ItemMeta meta = item.getItemMeta();
+        // if no meta is returned, we cant proceed
+        if (meta == null) {
+            return false;
         }
+
+        meta.setUnbreakable(true);
+        item.setItemMeta(meta);
+        return true;
     }
 
     public static boolean isUnbreakable(@Nullable ItemStack item) {