Merge pull request #10 from Smalls1652/update/refactor/embed-building

Move embed building to own method

Author: Smalls1652

src/App/Modules/ShareMusicCommandModule/commands/HandleGetLinksFromPostAsync.cs

@@ -83,12 +83,7 @@ await FollowupAsync(
 
             var linksComponentBuilder = GenerateMusicShareComponent(musicEntityItem);
 
-            var messageEmbed = new EmbedBuilder()
-                .WithTitle(streamingEntityItem.Title)
-                .WithDescription($"by {streamingEntityItem.ArtistName}")
-                .WithColor(Color.DarkBlue)
-                .WithImageUrl($"attachment://{streamingEntityItem.Title}.jpg")
-                .WithFooter("(Powered by Songlink/Odesli)");
+            var messageEmbed = GenerateEmbedBuilder(streamingEntityItem);
 
             await Context.Channel.SendFileAsync(
                 embed: messageEmbed.Build(),

src/App/Modules/ShareMusicCommandModule/commands/HandleMusicShareAsync.cs

@@ -70,21 +70,16 @@ await FollowupAsync(
         }
 
         StreamingEntityItem streamingEntityItem = musicEntityItem.EntitiesByUniqueId![platformEntityLink.EntityUniqueId!];
-        using var albumArtStream = await GetAlbumArtStreamAsync(streamingEntityItem);
+        await using var albumArtStream = await GetAlbumArtStreamAsync(streamingEntityItem);
 
         var linksComponentBuilder = GenerateMusicShareComponent(musicEntityItem);
 
-        var messageEmbed = new EmbedBuilder()
-            .WithTitle(streamingEntityItem.Title)
-            .WithDescription($"by {streamingEntityItem.ArtistName}")
-            .WithColor(Color.DarkBlue)
-            .WithImageUrl($"attachment://{streamingEntityItem.Title}.jpg")
-            .WithFooter("(Powered by Songlink/Odesli)");
+        var messageEmbed = GenerateEmbedBuilder(streamingEntityItem);
 
         await FollowupWithFileAsync(
             embed: messageEmbed.Build(),
             fileStream: albumArtStream,
-            fileName: $"{streamingEntityItem.Title}.jpg",
+            fileName: $"{streamingEntityItem.Id}.jpg",
             components: linksComponentBuilder.Build()
         );
 

src/App/Modules/ShareMusicCommandModule/helpers/GenerateEmbedBuilder.cs

@@ -0,0 +1,17 @@
+using Discord;
+using MuzakBot.App.Models.Odesli;
+
+namespace MuzakBot.App.Modules;
+
+public partial class ShareMusicCommandModule
+{
+    private EmbedBuilder GenerateEmbedBuilder(StreamingEntityItem streamingEntityItem)
+    {
+        return new EmbedBuilder()
+            .WithTitle(streamingEntityItem.Title)
+            .WithDescription($"by {streamingEntityItem.ArtistName}")
+            .WithColor(Color.DarkBlue)
+            .WithImageUrl($"attachment://{streamingEntityItem.Id}.jpg")
+            .WithFooter("(Powered by Songlink/Odesli)");
+    }
+}