test: mock data streams (#904)

Author: fireboss777

test/unit/Middlewares/Oracle/DataStreamsOracle/GetChainlinkDataStreamPrice.t.sol

@@ -1,9 +1,7 @@
 // SPDX-License-Identifier: UNLICENSED
 pragma solidity 0.8.26;
 
-import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
-
-import { EMPTY_STREAM_V3, EMPTY_STREAM_V4 } from "../../utils/Constants.sol";
+import { MOCK_STREAM_V3, MOCK_STREAM_V4 } from "../../utils/Constants.sol";
 import { OracleMiddlewareWithDataStreamsFixture } from "../../utils/Fixtures.sol";
 
 import { FormattedDataStreamsPrice } from "../../../../../src/interfaces/OracleMiddleware/IOracleMiddlewareTypes.sol";
@@ -42,7 +40,7 @@ contract TestChainlinkDataStreamsOracleGetPrice is OracleMiddlewareWithDataStrea
      * @custom:then The call should revert with `OracleMiddlewareInvalidReportVersion`.
      */
     function test_RevertWhen_getChainlinkDataStreamPriceIncorrectReportVersion() public {
-        report.feedId = EMPTY_STREAM_V4;
+        report.feedId = MOCK_STREAM_V4;
         (, payload) = _encodeReport(report);
         vm.expectRevert(OracleMiddlewareInvalidReportVersion.selector);
         oracleMiddleware.i_getChainlinkDataStreamPrice{ value: report.nativeFee }(payload, 0, 0);
@@ -54,7 +52,7 @@ contract TestChainlinkDataStreamsOracleGetPrice is OracleMiddlewareWithDataStrea
      * @custom:then The call should revert with `OracleMiddlewareInvalidStreamId`.
      */
     function test_RevertWhen_getChainlinkDataStreamPriceInvalidStreamId() public {
-        report.feedId = bytes32(uint256(EMPTY_STREAM_V3) | 1);
+        report.feedId = bytes32(uint256(MOCK_STREAM_V3) | 1);
         (, payload) = _encodeReport(report);
         vm.expectRevert(OracleMiddlewareInvalidStreamId.selector);
         oracleMiddleware.i_getChainlinkDataStreamPrice{ value: report.nativeFee }(payload, 0, 0);

test/unit/Middlewares/utils/Constants.sol

@@ -19,5 +19,5 @@ bytes constant REDSTONE_ETH_DATA =
     hex"00000000000000004554480000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000595cd5e4d5018fedf35ba00000002000000196c710f6ee933d08f86e99def2c6c64684808705691289aef63503f54bf8b9202d21cde463aeef0830cea7795a03cbebd92d51a7eb13134129fc82e3cac26e2e1b4554480000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000595cd4a962018fedf35ba0000000200000015bd816c1b59f67af5990b834c572b1e403a6a7ffcbc78e13510a0b7de750e02a4d0c641de3797cc2225fd6064f7445d0d77808ec620bd96f84e298bea049ac2f1c4554480000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000595cd5e4d5018fedf35ba000000020000001ab05ff923cef4ea56a1b77af4ea5f2700cab64628b44aaf460b7d9950dff4c1e74da926233820b52b78644fce28a97dc7b88c25bbe1dbd173ff69e8e3c1dcef01b0003000000000002ed57011e0000";
 
 uint256 constant STREAM_WSTETH_PRICE = 2300 ether;
-bytes32 constant EMPTY_STREAM_V3 = 0x0003000000000000000000000000000000000000000000000000000000000000;
-bytes32 constant EMPTY_STREAM_V4 = 0x0004000000000000000000000000000000000000000000000000000000000000;
+bytes32 constant MOCK_STREAM_V3 = 0x0003000000000000000000000000000000000000000000000000000000000000;
+bytes32 constant MOCK_STREAM_V4 = 0x0004000000000000000000000000000000000000000000000000000000000000;

test/unit/Middlewares/utils/Fixtures.sol

@@ -10,7 +10,7 @@ import { OracleMiddlewareHandler } from "../utils/Handler.sol";
 import { OracleMiddlewareWithRedstoneHandler } from "../utils/HandlerWithRedstone.sol";
 import { MockChainlinkOnChain } from "../utils/MockChainlinkOnChain.sol";
 import { MockPyth } from "../utils/MockPyth.sol";
-import { EMPTY_STREAM_V3, STREAM_WSTETH_PRICE } from "./Constants.sol";
+import { MOCK_STREAM_V3, STREAM_WSTETH_PRICE } from "./Constants.sol";
 import { OracleMiddlewareWithDataStreamsHandler } from "./Handler.sol";
 import { MockFeeManager } from "./MockFeeManager.sol";
 import { MockStreamVerifierProxy } from "./MockStreamVerifierProxy.sol";
@@ -173,11 +173,11 @@ contract OracleMiddlewareWithDataStreamsFixture is BaseFixture, ActionsFixture {
             address(mockChainlinkOnChain),
             chainlinkTimeElapsedLimit,
             address(mockStreamVerifierProxy),
-            EMPTY_STREAM_V3
+            MOCK_STREAM_V3
         );
 
         report = IVerifierProxy.ReportV3({
-            feedId: EMPTY_STREAM_V3,
+            feedId: MOCK_STREAM_V3,
             validFromTimestamp: uint32(block.timestamp),
             observationsTimestamp: uint32(block.timestamp),
             nativeFee: 0.001 ether,
@@ -366,11 +366,11 @@ contract WstethOracleWithDataStreamsBaseFixture is BaseFixture, ActionsFixture {
             address(wsteth),
             chainlinkTimeElapsedLimit,
             address(mockStreamVerifierProxy),
-            EMPTY_STREAM_V3
+            MOCK_STREAM_V3
         );
 
         report = IVerifierProxy.ReportV3({
-            feedId: EMPTY_STREAM_V3,
+            feedId: MOCK_STREAM_V3,
             validFromTimestamp: uint32(block.timestamp),
             observationsTimestamp: uint32(block.timestamp),
             nativeFee: 0.001 ether,