Merge pull request #2140 from pInksenberg/fix-an-issue-of-tuya-switch-duplicate-event-sending

fix an issue of Tuya button send duplicate event

Author: greens

drivers/Unofficial/tuya-zigbee/src/button/init.lua

@@ -39,12 +39,6 @@ local function added_handler(self, device)
   device:emit_event(capabilities.button.button.pushed({state_change = false}))
 end
 
-local function button_handler(event)
-  return function(driver, device, value, zb_rx)
-    device:emit_event(event)
-  end
-end
-
 local tuya_private_cluster_button_handler = function(driver, device, zb_rx)
   local event
   local additional_fields = {
@@ -79,9 +73,6 @@ local tuya_button_driver = {
   zigbee_handlers = {
     cluster = {
       [OnOff.ID] = {
-        [OnOff.server.commands.On.ID] = button_handler(capabilities.button.button.double({ state_change = true })),
-        [OnOff.server.commands.Off.ID] = button_handler(capabilities.button.button.held({ state_change = true })),
-        [OnOff.server.commands.Toggle.ID] = button_handler(capabilities.button.button.pushed({ state_change = true })),
         [PRESENT_ATTRIBUTE_ID] = tuya_private_cluster_button_handler
       }
     }

drivers/Unofficial/tuya-zigbee/src/test/test_tuya_button.lua

@@ -90,32 +90,6 @@ test.register_coroutine_test(
   end
 )
 
-test.register_coroutine_test(
-  "OnOff cluster any command (except On or Off) should result with sending pushed event",
-  function()
-    test.socket.zigbee:__queue_receive({
-      mock_device.id,
-      OnOff.server.commands.Toggle.build_test_rx(mock_device)
-    })
-    test.socket.capability:__expect_send(
-      mock_device:generate_test_message("main", button.button.pushed({ state_change = true }))
-    )
-  end
-)
-
-test.register_coroutine_test(
-  "OnOff cluster On command should result with sending double event",
-  function()
-    test.socket.zigbee:__queue_receive({
-      mock_device.id,
-      OnOff.server.commands.On.build_test_rx(mock_device)
-    })
-    test.socket.capability:__expect_send(
-      mock_device:generate_test_message("main", button.button.double({ state_change = true }))
-    )
-  end
-)
-
 test.register_coroutine_test(
   "OnOff cluster private command 0x01 should result with sending double event",
   function()
@@ -126,19 +100,6 @@ test.register_coroutine_test(
   end
 )
 
-test.register_coroutine_test(
-  "OnOff cluster Off command should result with sending held event",
-  function()
-    test.socket.zigbee:__queue_receive({
-      mock_device.id,
-      OnOff.server.commands.Off.build_test_rx(mock_device)
-    })
-    test.socket.capability:__expect_send(
-      mock_device:generate_test_message("main", button.button.held({ state_change = true }))
-    )
-  end
-)
-
 test.register_coroutine_test(
   "OnOff cluster private command 0x02 should result with sending held event",
   function()