improve test (WP-1004)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: vsolovei-smartling

tests/Smartling/WP/View/ContentEditJobViewTest.php

@@ -20,30 +20,52 @@ public function testHtmlDivTagsBalanceOnPostEditScreen(): void
         $this->assertDivBalanced($html, 'post edit screen ($needWrapper=false)');
     }
 
+    public function testHtmlDivTagsBalanceOnBulkSubmitScreen(): void
+    {
+        $html = $this->resolveTemplate(false, true);
+        $this->assertDivBalanced($html, 'bulk submit screen ($isBulkSubmitPage=true)');
+    }
+
     public function testHiddenWrapperHasClosingTag(): void
     {
-        $source = $this->stripNonHtml(file_get_contents(self::VIEW_FILE));
-        $hiddenOpens = preg_match_all('#<div\s+style\s*=\s*"display:\s*none#i', $source);
-        $this->assertGreaterThan(
-            0,
-            $hiddenOpens,
-            'Legacy display:none wrapper should still open (it hides the legacy .job-wizard fallback)'
+        $html = $this->resolveTemplate(false);
+
+        $this->assertSame(
+            1,
+            preg_match(
+                '#<div\s+style\s*=\s*"display:\s*none[^"]*"\s*>#i',
+                $html,
+                $matches,
+                PREG_OFFSET_CAPTURE
+            ),
+            'Hidden display:none wrapper opening <div> should exist'
+        );
+
+        $tail = substr($html, $matches[0][1]);
+        $opens = preg_match_all('#<div\b#i', $tail);
+        $closes = preg_match_all('#</div\s*>#i', $tail);
+
+        $this->assertSame(
+            $opens,
+            $closes,
+            'Hidden display:none wrapper must have a matching closing </div> ' .
+            '(an unclosed wrapper here is what caused WP-1004).'
         );
     }
 
-    private function resolveTemplate(bool $needWrapper): string
+    private function resolveTemplate(bool $needWrapper, bool $isBulkSubmitPage = false): string
     {
         $source = $this->stripNonHtml(file_get_contents(self::VIEW_FILE));
 
-        $source = preg_replace(
-            '#<\?php\s+if\s*\(\s*\$needWrapper\s*&&\s*false\s*\)\s*:\s*\?>(?:(?!<\?php\s+endif).)*<\?php\s+endif\s*;\s*\?>#s',
-            '',
+        $source = preg_replace_callback(
+            '#<\?php\s+if\s*\(\s*\$needWrapper\s*\)\s*:\s*\?>((?:(?!<\?php\s+endif).)*)<\?php\s+endif\s*;\s*\?>#s',
+            static fn(array $m): string => $needWrapper ? $m[1] : '',
             $source
         );
 
         $source = preg_replace_callback(
-            '#<\?php\s+if\s*\(\s*\$needWrapper\s*\)\s*:\s*\?>((?:(?!<\?php\s+endif).)*)<\?php\s+endif\s*;\s*\?>#s',
-            static fn(array $m): string => $needWrapper ? $m[1] : '',
+            '#<\?php\s+if\s*\(\s*!\$isBulkSubmitPage\s*\)\s*:\s*\?>((?:(?!<\?php\s+endif).)*)<\?php\s+endif\s*;\s*\?>#s',
+            static fn(array $m): string => $isBulkSubmitPage ? '' : $m[1],
             $source
         );