A `like` filter resolves to the incorrect query type causing an exception in development mode

[speller]

Preconditions

Magento Version : 2.4.3

ElasticSuite Version : 2.10.9

Environment : Developer

Third party modules : many but doesn't seem to be involved in the bug.

Steps to reproduce

• Development mode.
• Remove generated DI files.
• Code:

$categoryCollectionFactory = $objectManager->create('Smile\ElasticsuiteCatalog\Model\ResourceModel\Category\Fulltext\CollectionFactory')
$categoryCollection = $categoryCollectionFactory->create();
$categoryCollection->addFieldToFilter('path', ['like' => '1/2/%']);

return $categoryCollection->getFirstItem();

Expected result

1. A search result.

Actual result

Exception

Missing required argument $values of Smile\ElasticsuiteCore\Search\Request\Query\Terms.

vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:264

The issue evolves in the following way:

• The path field has the following definition: <field name="path" type="keyword" />.
• This creates a Smile\ElasticsuiteCore\Index\Mapping\Field object with the default analyzer set to standard.
• The Field::checkAnalyzer() method returns false (can't get the idea of this method).
• It leads to returning null from the Field::getMappingProperty() method.
• In the Smile\ElasticsuiteCore\Search\Request\Query\Filter\QueryBuilder::prepareFieldCondition this loses the chance to switch the $queryType value from QueryInterface::TYPE_TERMS to QueryInterface::TYPE_MATCH.
• Due to the query type set to TYPE_TERMS, it then tries to instantiate a Smile\ElasticsuiteCore\Search\Request\Query\Terms object through the Magento\Framework\ObjectManager\Factory\AbstractFactory and passes the following parameters to it:

  Array
  (
    [field] => path 
    [queryText] => 1/2/%
  )

• As the Query\Terms' constructor doesn't have the $queryText argument, and the supplied array doesn't have the values key, the Magento\Framework\ObjectManager\Factory\AbstractFactory::getResolvedArgument() throws the Missing required argument $values of Smile\ElasticsuiteCore\Search\Request\Query\Terms exception.

I suppose that ElasticSuite should set the query type to TYPE_MATCH in the Smile\ElasticsuiteCore\Search\Request\Query\Filter\QueryBuilder::prepareFieldCondition to pick the proper class Smile\ElasticsuiteCore\Search\Request\Query\MatchQuery which contains the $queryText constructor argument.

This exception doesn't happen when the DI container is compiled because Magento substitutes a null value to the Terms query class $values argument in that case. This leads to that it uses the Terms query object for the path field with the null query value which is wrong and doesn't reflect the intended filtering behavior.

[vahonc]

Hello @speller,

Could you provide more details on what exactly you want to do and explain why you want to use a collection from the ES module for this?

BR,
Vadym

[speller]

The goal is to filter categories by parent path

[romainruaud]

@speller if you just want to filter by parent path, you should use the legacy Magento collection to do this.

Regards

[speller]

@romainruaud I just double-checked the existing code (written not by me) and found that the code filters by parent category and url_key:

        $categoryCollection = $this->categoryCollectionFactory->create();
        $categoryCollection->addFieldToFilter('path', ['like' => '1/'.$storeRootCategory.'/%'])
                           ->addFieldToFilter('url_key', $category);

        return $categoryCollection->getFirstItem();

Could you advise a better solution for that?

[romainruaud]

You should just use the legacy \Magento\Catalog\Model\ResourceModel\Category\CollectionFactory as the $categoryCollectionFactory, not the implementation from Elasticsuite.

The elasticsuite implementation is meant to be used for fulltext matching on category data, which is clearly not the case here. This should be achieved using the legacy collection.

Regards

[speller]

@romainruaud It seems the proposed solution works, thank you

[aligent-lturner]

@romainruaud sorry to resurrect a very old issue, but I'm experiencing a similar issue currently.
We're using the GraphQL products query, and passing in a filter on a custom attribute (which is a text attribute). The same logic flow seems to happen - the mapping property comes back as null, so the type is kept as Terms instead of MatchQuery, and we get this error:

{
  "errors": [
    {
      "message": "Internal server error",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "products"
      ],
      "extensions": {
        "debugMessage": "Missing required argument $values of Smile\\ElasticsuiteCore\\Search\\Request\\Query\\Terms."
      }
    }
  ],
  "data": {
    "products": null
  }
}

The query used was:

products(
    filter: {
      a884347017: {
        match: "4 stud"
      }
    }

a8843447017 is a filterable attribute (it will be named differently later - this is in dev at the moment)