Skip to content

Error in sample code checking flags #66

Open
@timglauertadder

Description

@timglauertadder

The sample code contains the follow tests:

.read((flags & O_RDONLY != 0) | (flags & O_RDWR != 0))
.write((flags & O_WRONLY != 0) | (flags & O_RDWR != 0))

However O_RDONLY is 0 so the test is bogus and gives a clippy warning.

The O_XXXXvalues are not bit masks but rather they are values for the two low order bits of the flags value. The tests should probably look somethign like this:

.read((flags & 3) == O_RDONLY || (flags & 3) == O_RDWR)
.write((flags & 3) == O_WRONLY || (flags & 3) == O_RDWR)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions