Skip to content

Commit 056e1d0

Browse files
Remove percentage calculation
1 parent 7633c08 commit 056e1d0

File tree

2 files changed

+4
-44
lines changed

2 files changed

+4
-44
lines changed

samples/cooperative_matrix/code/main/cooperative_matrix_tester.cpp

Lines changed: 4 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -735,15 +735,6 @@ void CooperativeMatrixRunner::RenderUI()
735735
ImGui::EndDisabled();
736736
}
737737

738-
if (ImGui::CollapsingHeader("Device Configuration", 0))
739-
{
740-
ImGui::Text("Default values for [SM8750][Adreno830] - Change as needed");
741-
ImGui::DragInt("GPU Frequency MHz", &m_gpu_freq_MHz, 1.0f, 0, 999999);
742-
ImGui::DragInt("GPU Micro SP", &m_gpu_microSP, 1.0f, 0, 999999);
743-
ImGui::DragInt("GPU ALU per Micro SP", &m_gpu_ALU_per_microSP, 1.0f, 0, 999999);
744-
ImGui::DragInt("GPU OPs per MAD", &m_gpu_ops_per_mad, 1.0f, 0, 999999);
745-
}
746-
747738
ImGui::Separator();
748739

749740
if (ImGui::Button("Run Tests"))
@@ -761,8 +752,6 @@ void CooperativeMatrixRunner::RenderUI()
761752
ImGui::BeginDisabled(disable_ui);
762753
}
763754

764-
ImGui::Text("For accurate values, make sure you are using the right device configurations (check 'Device Configuration' tab)");
765-
766755
if (!m_test_groups.empty())
767756
{
768757
for (int i=0; i< m_test_groups.size(); i++)
@@ -874,9 +863,9 @@ void CooperativeMatrixRunner::RenderUI()
874863
ImGui::TextDisabled("WxH = %dx%d", test_description.inputWidth, test_description.inputHeight);
875864

876865
ImVec4 color = GetPercentageColor(test_result.percentage / 100.0f);
877-
ImGui::PushStyleColor(ImGuiCol_Text, color);
878-
ImGui::Text("[%%]: %.2f", test_result.percentage);
879-
ImGui::PopStyleColor();
866+
// ImGui::PushStyleColor(ImGuiCol_Text, color);
867+
// ImGui::Text("[%%]: %.2f", test_result.percentage);
868+
// ImGui::PopStyleColor();
880869
}
881870
else
882871
{
@@ -963,7 +952,6 @@ void CooperativeMatrixRunner::PrepareTestSession()
963952
TestDescription new_test_description;
964953

965954
new_test_description.fill_data_type = m_fill_data_type;
966-
new_test_description.gpu_freq_MHz = m_gpu_freq_MHz;
967955
new_test_description.test_type = m_test_type;
968956

969957
new_test_description.inputWidth = m_input_width;
@@ -1017,8 +1005,6 @@ std::optional<CooperativeMatrixRunner::TestResult> CooperativeMatrixRunner::RunT
10171005

10181006
VkResult result;
10191007

1020-
uint32_t gpu_freq_MHz = test_description.gpu_freq_MHz;
1021-
10221008
int MSize = test_description.MSize;
10231009
int NSize = test_description.NSize;
10241010
int KSize = test_description.KSize;
@@ -1712,17 +1698,6 @@ std::optional<CooperativeMatrixRunner::TestResult> CooperativeMatrixRunner::RunT
17121698

17131699
if(gpuvendor_id == VK_VENDOR_ID_QUALCOMM )
17141700
{
1715-
uint32_t num_uSP;
1716-
switch (gputier_id)
1717-
{
1718-
case QCOM_TIER_3:
1719-
case QCOM_TIER_4:
1720-
num_uSP = 16;
1721-
break;
1722-
default:
1723-
num_uSP = 12;
1724-
}
1725-
17261701
uint64_t total_ops = 0;
17271702
if (tt == TT_CONV)
17281703
{
@@ -1739,20 +1714,11 @@ std::optional<CooperativeMatrixRunner::TestResult> CooperativeMatrixRunner::RunT
17391714
static_cast<uint64_t>(testCase.TOTAL_K) * 2;
17401715
}
17411716

1742-
uint32_t theoreticalTime_ns = 1000 * ((unsigned long int)testCase.TOTAL_M * testCase.TOTAL_N * testCase.TOTAL_K / 64 / 2 / num_uSP / (4 / bytesPerInput)) / gpu_freq_MHz;
1743-
if (tt == TT_CONV)
1744-
theoreticalTime_ns = 1000 * ((unsigned long int)testCase.TOTAL_M * testCase.TOTAL_N * testCase.TOTAL_K * filterHeight * filterWidth / 64 / 2 / num_uSP / (4 / bytesPerInput)) / gpu_freq_MHz;
1745-
1746-
std::cout << "Maximum theoretical perf on device @" << gpu_freq_MHz << "MHz is " << theoreticalTime_ns / 1000 << "us." << std::endl;
17471717
ms /= double(perf_loop);
1748-
double percentOfPeak_avg = 100 * theoreticalTime_ns / ms / 1000 / 1000;
1749-
double percentOfPeak_min = 100 * theoreticalTime_ns / min_ms / 1000 / 1000;
1750-
std::cout << "MxM kernel time, average of " << perf_loop << " run(s): " << ms * 1000 << "us (" << percentOfPeak_avg << "% of theoretical peak (assuming " << gpu_freq_MHz << "MHz frequency))\n";
1751-
std::cout << "MxM kernel time, min of " << perf_loop << " run(s): " << min_ms * 1000 << "us (" << percentOfPeak_min << "% of theoretical peak (assuming " << gpu_freq_MHz << "MHz frequency))\n";
17521718

17531719
test_result.time_total = ms * 1000;
17541720
test_result.TOPS = static_cast<double>(total_ops) / (ms / 1000.0) / 1e12;
1755-
test_result.percentage = percentOfPeak_avg;
1721+
test_result.percentage = 0.0;
17561722
}
17571723
else
17581724
{

samples/cooperative_matrix/code/main/cooperative_matrix_tester.hpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ class CooperativeMatrixRunner
4040
TestType test_type = TT_MXM_BASIC;
4141
FillDataType fill_data_type = FILL_WITH_RANDON_INT;
4242

43-
uint32_t gpu_freq_MHz = 900;
44-
4543
VkComponentTypeKHR input_type;
4644
VkComponentTypeKHR output_type;
4745

@@ -129,10 +127,6 @@ class CooperativeMatrixRunner
129127

130128
TestType m_test_type = TT_MXM_BASIC;
131129
FillDataType m_fill_data_type = FILL_WITH_RANDON_INT;
132-
int32_t m_gpu_freq_MHz = 900;
133-
int32_t m_gpu_microSP = 12;
134-
int32_t m_gpu_ALU_per_microSP = 2;
135-
int32_t m_gpu_ops_per_mad = 2;
136130

137131
MatrixTransposeOption m_matrix_transpose_options[NUM_MATS] = { VARIABLE , VARIABLE , VARIABLE , ALWAYS_FALSE };
138132

0 commit comments

Comments
 (0)