Rename ScrubUserMappingSecrets to RedactUserMappingSecrets; fix style

Author: sfc-gh-npuka

pg_lake_iceberg/include/pg_lake/rest_catalog/rest_catalog.h

@@ -131,5 +131,6 @@ extern PGDLLEXPORT RestCatalogRequest * GetRemoveSnapshotCatalogRequest(List *re
 /* ProcessUtility handlers */
 /* iceberg_catalog server DDL validation */
 extern PGDLLEXPORT bool ValidateIcebergCatalogServerDDL(ProcessUtilityParams * processUtilityParams, void *arg);
+
 /* scrubs user mapping secrets in-place */
-extern PGDLLEXPORT bool RedactRestCatalogUserMappingSecrets(ProcessUtilityParams *processUtilityParams, void *arg);
+extern PGDLLEXPORT bool RedactRestCatalogUserMappingSecrets(ProcessUtilityParams * processUtilityParams, void *arg);

pg_lake_iceberg/src/rest_catalog/rest_catalog.c

@@ -243,22 +243,22 @@ IsIcebergCatalogServer(const char *serverName)
 
 
 /*
- * ScrubUserMappingSecrets overwrites secret option values in the query
+ * RedactUserMappingSecrets overwrites secret option values in the query
  * string in-place with asterisks.
  *
  * In-place mutation is essential: pg_stat_statements captures the queryString
  * pointer before calling prev_ProcessUtility, then stores it after the call
  * returns. A copy with pstrdup would be invisible to pg_stat_statements
  * because its local pointer still references the original memory. By
  * overwriting the original buffer, every holder of that pointer — including
- * pg_stat_statements — sees the scrubbed version.
+ * pg_stat_statements — sees the redacted version.
  *
  * The actual DDL execution is unaffected because CREATE/ALTER USER MAPPING
  * reads option values from the parse tree (DefElem nodes), not from
  * queryString.
  */
 static void
-ScrubUserMappingSecrets(const char *queryString, List *options)
+RedactUserMappingSecrets(const char *queryString, List *options)
 {
 	const char *secret_options[] = {"client_id", "client_secret", NULL};
 	ListCell   *lc;
@@ -339,7 +339,7 @@ RedactRestCatalogUserMappingSecrets(ProcessUtilityParams * processUtilityParams,
 	if (!IsIcebergCatalogServer(serverName))
 		return false;
 
-	ScrubUserMappingSecrets(processUtilityParams->queryString, options);
+	RedactUserMappingSecrets(processUtilityParams->queryString, options);
 
 	return false;
 }
@@ -655,13 +655,14 @@ GetRestCatalogOptionsFromCatalog(const char *catalog)
 	}
 
 	/*
-	 * User mapping has highest priority — overrides everything above
-	 * Can only be set for user-created servers
+	 * User mapping has highest priority — overrides everything above Can
+	 * only be set for user-created servers
 	 */
 	if (server != NULL)
 	{
 		List	   *umOptions = LookupUserMappingOptions(server->serverid);
 		ListCell   *lc;
+
 		foreach(lc, umOptions)
 		{
 			DefElem    *def = (DefElem *) lfirst(lc);