Skip to content

Commit f2d4a28

Browse files
pgduck client: include conninfo in start-failure error
Add an errdetail() clause to the "could not start query engine" ereport() so users can see which connection string was being used when the connection to pgduck_server failed. Issue: #293 Signed-off-by: David Christensen <david.christensen@snowflake.com>
1 parent cb24419 commit f2d4a28

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

pg_lake_engine/src/pgduck/client.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,14 @@ GetPGDuckConnection(void)
144144
PQfinish(connection);
145145

146146
#ifdef USE_ASSERT_CHECKING
147-
ereport(ERROR, (errmsg("could not start query engine: %s", errorMessage)));
147+
ereport(ERROR,
148+
(errmsg("could not start query engine: %s", errorMessage),
149+
errdetail("connection string: %s", PgduckServerConninfo)));
148150
#else
149151
/* hide internals from users */
150-
ereport(ERROR, (errmsg("could not start query engine")));
152+
ereport(ERROR,
153+
(errmsg("could not start query engine"),
154+
errdetail("connection string: %s", PgduckServerConninfo)));
151155
#endif
152156
}
153157

0 commit comments

Comments
 (0)