Merge pull request #26 from Snowflake-Labs/fix-s3-bucket-policy

Fix S3 bucket policy

Author: sfc-gh-pkommini

s3.tf

@@ -21,12 +21,9 @@ resource "aws_s3_bucket_acl" "logs_bucket_acl" {
   depends_on = [aws_s3_bucket_ownership_controls.logs_bucket_ownership[0]]
 }
 
-resource "aws_s3_bucket_policy" "allow_access_from_eks" {
-  bucket = aws_s3_bucket.logs_bucket[0].id
-  policy = data.aws_iam_policy_document.allow_access_from_eks.json
-}
-
 data "aws_iam_policy_document" "allow_access_from_eks" {
+  count = var.create_logs_bucket == true ? 1 : 0
+
   statement {
     effect = "Allow"
 
@@ -43,3 +40,10 @@ data "aws_iam_policy_document" "allow_access_from_eks" {
     ]
   }
 }
+
+resource "aws_s3_bucket_policy" "allow_access_from_eks" {
+  count = var.create_logs_bucket == true ? 1 : 0
+
+  bucket = aws_s3_bucket.logs_bucket[0].id
+  policy = data.aws_iam_policy_document.allow_access_from_eks[0].json
+}