Merge pull request #7 from Snowflake-Labs/SNOW-780555-public-dns-decommission

SNOW-780555: Add option to use private dns zone for external traffic, i.e for VPN

Author: sfc-gh-bkou

helm_external_dns.tf

@@ -13,7 +13,7 @@ resource "helm_release" "external_dns" {
       "${path.module}/templates/external_dns_values.yaml",
       {
         aws_region                       = "${var.aws_region}",
-        aws_zone_type                    = "public",
+        aws_zone_type                    = "${var.aws_public_hosted_zone_type}",
         aws_public_hosted_zone           = "${local.public_hosted_zone_id}"
         external_dns_eks_service_account = "${aws_iam_role.external_dns_role[0].name}",
         aws_iam_role_external_dns        = "${aws_iam_role.external_dns_role[0].name}",

helm_external_dns_private.tf

@@ -13,6 +13,7 @@ resource "helm_release" "external_dns_private" {
       "${path.module}/templates/external_dns_private_values.yaml",
       {
         aws_region                       = "${var.aws_region}",
+        aws_zone_type                    = "${var.aws_private_hosted_zone_type}",
         aws_private_hosted_zone          = "${local.private_hosted_zone_id}",
         external_dns_eks_service_account = "${aws_iam_role.external_dns_private_role[0].name}",
         aws_iam_role_external_dns        = "${aws_iam_role.external_dns_private_role[0].name}",

templates/external_dns_private_values.yaml

@@ -1,7 +1,7 @@
 provider: aws
 aws:
   region: ${aws_region}
-  zoneType: private
+  zoneType: ${aws_zone_type}
 sources:
   - service
   - ingress

templates/external_dns_values.yaml

@@ -1,7 +1,7 @@
 provider: aws
 aws:
   region: ${aws_region}
-  zoneType: public
+  zoneType: ${aws_zone_type}
 sources:
   - service
   - ingress

variables.tf

@@ -36,12 +36,25 @@ variable "aws_public_hosted_zone" {
   default     = null
 }
 
+variable "aws_public_hosted_zone_type" {
+  description = "Public hosted zone type - public or private."
+  type        = string
+  default     = "public"
+}
+
 variable "aws_private_hosted_zone" {
   description = "Private Hosted zone subdomain."
   type        = string
   default     = null
 }
 
+variable "aws_private_hosted_zone_type" {
+  description = "Private hosted zone type - public or private."
+  type        = string
+  default     = "private"
+}
+
+
 # Optional
 variable "arn_format" {
   type        = string