Skip to content

Commit bc29f37

Browse files
committed
fix: handle namespace in requirement and remove deprecated use of extraResources
1 parent 58e05bb commit bc29f37

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

pkg/grpc/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ func buildResponse(rsp *fnv1.RunFunctionResponse, jsResponse *JSResponse, resour
316316
if rsp.Requirements == nil {
317317
rsp.Requirements = &fnv1.Requirements{}
318318
}
319-
rsp.Requirements.ExtraResources = extraResources
319+
rsp.Requirements.Resources = extraResources
320320
}
321321

322322
// Process conditions if present

pkg/grpc/localresource.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,10 @@ func (e *ExtraResourceRequirement) ToResourceSelector() *fnv1.ResourceSelector {
6666
// ExtraResourceRequirement.Namespace yet. Leaving it here keeps the JSON
6767
// contract ready for future SDKs without breaking compilation today.
6868

69+
if e.Namespace != "" {
70+
out.Namespace = &e.Namespace
71+
}
72+
6973
return out
7074
}
7175

0 commit comments

Comments
 (0)