fix: tests e2e (#2915)

Co-authored-by: Gary van Woerkens <gary.van-woerkens@sg.social.gouv.fr>

Author: Viczei

packages/app/src/e2e/declaration.e2e.ts

@@ -3,6 +3,11 @@ import { expect, test } from "@playwright/test";
 import { loginWithProConnect } from "./helpers/login";
 
 test.describe("Declaration workflow", () => {
+	test.skip(
+		!process.env.SITE_URL,
+		"Requires a deployed environment with ProConnect",
+	);
+
 	test.beforeEach(async ({ page }) => {
 		await loginWithProConnect(page);
 	});

packages/app/src/e2e/helpers/login.ts

@@ -1,10 +1,19 @@
 import type { Page } from "@playwright/test";
 
+/** Dismiss the cookie consent banner if present. */
+export async function dismissCookieBanner(page: Page) {
+	const refuseButton = page.getByRole("button", { name: "Tout refuser" });
+	if (await refuseButton.isVisible({ timeout: 2000 }).catch(() => false)) {
+		await refuseButton.click();
+	}
+}
+
 /** Log in via ProConnect using the FIA1V2 test identity provider. */
 export async function loginWithProConnect(page: Page) {
 	await page.goto("/login");
+	await dismissCookieBanner(page);
 	await page
-		.getByRole("button", { name: /s'identifier avec\s*proconnect/i })
+		.getByRole("button", { name: /s.identifier avec\s*proconnect/i })
 		.click();
 
 	// Fill ProConnect login form with the FIA1V2 test identity

packages/app/src/e2e/login.e2e.ts

@@ -1,30 +1,28 @@
 import { expect, test } from "@playwright/test";
 
-import { loginWithProConnect } from "./helpers/login";
+import { dismissCookieBanner, loginWithProConnect } from "./helpers/login";
 
 test.describe("Login page", () => {
-	test("displays ProConnect button and accordion", async ({ page }) => {
+	test("displays ProConnect button", async ({ page }) => {
 		await page.goto("/login");
+		await dismissCookieBanner(page);
 
 		await expect(
-			page.getByRole("button", { name: /s'identifier avec\s*proconnect/i }),
-		).toBeVisible();
-
-		// Accordion with account creation help
-		await expect(
-			page.getByRole("button", {
-				name: /vous n'avez pas de compte/i,
-			}),
+			page.getByRole("button", { name: /s.identifier avec\s*proconnect/i }),
 		).toBeVisible();
 	});
 });
 
 test.describe("ProConnect authentication flow", () => {
+	test.skip(
+		!process.env.SITE_URL,
+		"Requires a deployed environment with ProConnect",
+	);
+
 	test("redirects to declaration page after login", async ({ page }) => {
 		await loginWithProConnect(page);
 
 		await page.waitForURL("**/declaration-remuneration");
-		// Authenticated state is confirmed by the user-menu button
 		await expect(
 			page.getByRole("button", { name: "Mon espace" }),
 		).toBeVisible();
@@ -37,7 +35,6 @@ test.describe("ProConnect authentication flow", () => {
 	test("shows user menu in header after login", async ({ page }) => {
 		await loginWithProConnect(page);
 
-		// "Mon espace" button should appear instead of "Se connecter"
 		await expect(
 			page.getByRole("button", { name: "Mon espace" }),
 		).toBeVisible();
@@ -46,10 +43,8 @@ test.describe("ProConnect authentication flow", () => {
 	test("displays user info in account menu", async ({ page }) => {
 		await loginWithProConnect(page);
 
-		// Open user menu
 		await page.getByRole("button", { name: "Mon espace" }).click();
 
-		// Verify logout menu item is available (role="menuitem" on the link)
 		await expect(
 			page.getByRole("menuitem", { name: "Se déconnecter" }),
 		).toBeVisible();
@@ -58,20 +53,15 @@ test.describe("ProConnect authentication flow", () => {
 	test("logs out and returns to unauthenticated state", async ({ page }) => {
 		await loginWithProConnect(page);
 
-		// Open user menu and click logout
 		await page.getByRole("button", { name: "Mon espace" }).click();
 		await page.getByRole("menuitem", { name: "Se déconnecter" }).click();
 
-		// NextAuth shows a sign-out confirmation page with a CSRF form.
-		// The button label "Sign out" is NextAuth's default English copy;
-		// update this selector if the sign-out page is ever customised.
 		await page.waitForURL("**/api/auth/signout**");
 		await page.getByRole("button", { name: /sign out/i }).click();
 
-		// After sign-out, NextAuth redirects to the login page
 		await page.waitForURL("**/login", { timeout: 10000 });
 		await expect(
-			page.getByRole("button", { name: /s'identifier avec\s*proconnect/i }),
+			page.getByRole("button", { name: /s.identifier avec\s*proconnect/i }),
 		).toBeVisible();
 	});
 
@@ -80,10 +70,8 @@ test.describe("ProConnect authentication flow", () => {
 	}) => {
 		await loginWithProConnect(page);
 
-		// Navigate to /login while already authenticated
 		await page.goto("/login");
 
-		// Should be redirected to /declaration-remuneration
 		await page.waitForURL("**/declaration-remuneration");
 		await expect(
 			page.getByRole("heading", {