refactor(domain): extract hasRequiredDeclarationInfo predicate

Move the inline `!userPhone || hasCse === null` check into a pure
domain function, as suggested in PR review by maxgfr and Viczei.

Author: LucasCharrier

packages/app/src/modules/domain/__tests__/declarationPrerequisites.test.ts

@@ -0,0 +1,26 @@
+import { describe, expect, it } from "vitest";
+
+import { hasRequiredDeclarationInfo } from "../shared/declarationPrerequisites";
+
+describe("hasRequiredDeclarationInfo", () => {
+	it("returns true when phone and CSE are provided", () => {
+		expect(hasRequiredDeclarationInfo("0612345678", true)).toBe(true);
+		expect(hasRequiredDeclarationInfo("0612345678", false)).toBe(true);
+	});
+
+	it("returns false when phone is missing", () => {
+		expect(hasRequiredDeclarationInfo(null, true)).toBe(false);
+	});
+
+	it("returns false when CSE is null", () => {
+		expect(hasRequiredDeclarationInfo("0612345678", null)).toBe(false);
+	});
+
+	it("returns false when both are missing", () => {
+		expect(hasRequiredDeclarationInfo(null, null)).toBe(false);
+	});
+
+	it("returns false when phone is empty string", () => {
+		expect(hasRequiredDeclarationInfo("", true)).toBe(false);
+	});
+});

packages/app/src/modules/domain/index.ts

@@ -19,6 +19,8 @@ export {
 	GAP_ALERT_THRESHOLD,
 	MAX_CSE_FILES,
 } from "./shared/constants";
+// Declaration prerequisites
+export { hasRequiredDeclarationInfo } from "./shared/declarationPrerequisites";
 // Declaration status
 export { computeDeclarationStatus } from "./shared/declarationStatus";
 // Display formatting (%, €, units)

packages/app/src/modules/domain/shared/declarationPrerequisites.ts

@@ -0,0 +1,7 @@
+/** Returns true if the user has provided all required info to start a declaration (phone + CSE status). */
+export function hasRequiredDeclarationInfo(
+	userPhone: string | null,
+	hasCse: boolean | null,
+): boolean {
+	return !!userPhone && hasCse !== null;
+}

packages/app/src/modules/my-space/CompanyDeclarationsPage.tsx

@@ -1,4 +1,4 @@
-import { getCurrentYear } from "~/modules/domain";
+import { getCurrentYear, hasRequiredDeclarationInfo } from "~/modules/domain";
 
 import { ArchivesSection } from "./ArchivesSection";
 import { CompanyEditModal } from "./CompanyEditModal";
@@ -60,7 +60,7 @@ export function CompanyDeclarationsPage({
 			/>
 			<ArchivesSection />
 			<CompanyEditModal company={company} />
-			{(!userPhone || company.hasCse === null) && (
+			{!hasRequiredDeclarationInfo(userPhone, company.hasCse) && (
 				<MissingInfoModal
 					hasCse={company.hasCse}
 					siren={company.siren}

packages/app/src/modules/my-space/DeclarationLink.tsx

@@ -1,5 +1,7 @@
 "use client";
 
+import { hasRequiredDeclarationInfo } from "~/modules/domain";
+
 import { DECLARATION_PROCESS_PANEL_ID } from "./DeclarationProcessPanel";
 import type { DeclarationType } from "./types";
 
@@ -21,7 +23,7 @@ export function DeclarationLink({
 	hasCse,
 	children,
 }: Props) {
-	const hasMissingInfo = !userPhone || hasCse === null;
+	const hasMissingInfo = !hasRequiredDeclarationInfo(userPhone, hasCse);
 
 	// When info is missing, open missing-info modal (for both types)
 	if (hasMissingInfo) {