fix(e2e): add cleanup after login + enable CI screenshots/videos

- Clean declarations after login (inside it() block) so retry attempts
  start from clean state — Cypress doesn't run afterEach between retries
- Enable video recording and screenshots in CI for debugging failures
- Upload Cypress artifacts (screenshots/videos) on failure
- Log cleanup endpoint response for debugging

Author: Viczei

.github/workflows/e2e.yaml

@@ -42,9 +42,20 @@ jobs:
         run: |
           pnpm test:e2e:app
         env:
+          CI: "true"
           working-directory: ./packages/app
           config: "pageLoadTimeout=100000,baseUrl=${{ env.SITE_URL }}"
           TEST_BASEURL: ${{ env.SITE_URL }}
           E2E_USERNAME: ${{ github.ref == 'refs/heads/master' && secrets.E2E_USERNAME || 'test@fia1.fr' }}
           E2E_PASSWORD: ${{ github.ref == 'refs/heads/master' && secrets.E2E_PASSWORD || 'test' }}
           KEYCLOAK_URL: ${{ env.KEYCLOAK_URL }}
+
+      - name: Upload Cypress artifacts
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: cypress-artifacts
+          path: |
+            packages/app/cypress/screenshots
+            packages/app/cypress/videos
+          retention-days: 7

packages/app/cypress.config.ts

@@ -4,8 +4,8 @@ import { defineConfig } from "cypress";
 export default defineConfig({
   defaultCommandTimeout: 30000,
   experimentalStudio: true,
-  video: false,
-  screenshotOnRunFailure: false,
+  video: !!process.env.CI,
+  screenshotOnRunFailure: true,
   retries: {
     runMode: 2, // Réessayer 2 fois en mode CI
     openMode: 0, // Pas de réessai en mode interactif

packages/app/cypress/e2e/declaration_1000_employees_firm.cy.ts

@@ -6,11 +6,13 @@ describe("Declaration", () => {
     cy.clearCookies();
   });
   afterEach(() => {
-    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false }).then((response) => { cy.log(`Clean endpoint: status=${response.status}, body=${JSON.stringify(response.body)}`); });
   });
 
   it("Doit compléter le parcours du simulateur jusqu'à la page de récapitulatif", () => {
     cy.loginWithKeycloak();
+    // Clean any leftover declarations (important for retry attempts)
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
 
     // Visiter la page de démarrage du simulateur
     cy.visit("/");

packages/app/cypress/e2e/declaration_1000_employees_firm_2.cy.ts

@@ -6,11 +6,13 @@ describe("Declaration", () => {
     cy.clearCookies();
   });
   afterEach(() => {
-    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false }).then((response) => { cy.log(`Clean endpoint: status=${response.status}, body=${JSON.stringify(response.body)}`); });
   });
 
   it("Doit compléter le parcours du simulateur jusqu'à la page de récapitulatif", () => {
     cy.loginWithKeycloak();
+    // Clean any leftover declarations (important for retry attempts)
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
 
     // Visiter la page de démarrage du simulateur
     cy.visit("/");

packages/app/cypress/e2e/declaration_251-999_employees_firm_1.cy.ts

@@ -6,11 +6,13 @@ describe("Declaration", () => {
     cy.clearCookies();
   });
   afterEach(() => {
-    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false }).then((response) => { cy.log(`Clean endpoint: status=${response.status}, body=${JSON.stringify(response.body)}`); });
   });
 
   it("Doit compléter le parcours du simulateur jusqu'à la page de récapitulatif", () => {
     cy.loginWithKeycloak();
+    // Clean any leftover declarations (important for retry attempts)
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
 
     // Visiter la page de démarrage du simulateur
     cy.visit("/");

packages/app/cypress/e2e/declaration_251-999_employees_firm_2.cy.ts

@@ -6,11 +6,13 @@ describe("Declaration", () => {
     cy.clearCookies();
   });
   afterEach(() => {
-    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false }).then((response) => { cy.log(`Clean endpoint: status=${response.status}, body=${JSON.stringify(response.body)}`); });
   });
 
   it("Doit compléter le parcours du simulateur jusqu'à la page de récapitulatif", () => {
     cy.loginWithKeycloak();
+    // Clean any leftover declarations (important for retry attempts)
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
 
     // Visiter la page de démarrage du simulateur
     cy.visit("/");

packages/app/cypress/e2e/declaration_50-250_employees_firm_1.cy.ts

@@ -6,11 +6,13 @@ describe("Declaration", () => {
     cy.clearCookies();
   });
   afterEach(() => {
-    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false }).then((response) => { cy.log(`Clean endpoint: status=${response.status}, body=${JSON.stringify(response.body)}`); });
   });
 
   it("Doit compléter le parcours du simulateur jusqu'à la page de récapitulatif", () => {
     cy.loginWithKeycloak();
+    // Clean any leftover declarations (important for retry attempts)
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
 
     // Visiter la page de démarrage du simulateur
     cy.visit("/");

packages/app/cypress/e2e/declaration_50-250_employees_firm_2.cy.ts

@@ -6,11 +6,13 @@ describe("Declaration", () => {
     cy.clearCookies();
   });
   afterEach(() => {
-    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false }).then((response) => { cy.log(`Clean endpoint: status=${response.status}, body=${JSON.stringify(response.body)}`); });
   });
 
   it("Doit compléter le parcours du simulateur jusqu'à la page de récapitulatif", () => {
     cy.loginWithKeycloak();
+    // Clean any leftover declarations (important for retry attempts)
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
 
     // Visiter la page de démarrage du simulateur
     cy.visit("/");

packages/app/cypress/e2e/declaration_50-250_employees_firm_3.cy.ts

@@ -6,11 +6,13 @@ describe("Declaration", () => {
     cy.clearCookies();
   });
   afterEach(() => {
-    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false }).then((response) => { cy.log(`Clean endpoint: status=${response.status}, body=${JSON.stringify(response.body)}`); });
   });
 
   it("Doit compléter le parcours du simulateur jusqu'à la page de récapitulatif", () => {
     cy.loginWithKeycloak();
+    // Clean any leftover declarations (important for retry attempts)
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
 
     // Visiter la page de démarrage du simulateur
     cy.visit("/");

packages/app/cypress/e2e/declaration_50-250_employees_firm_4.cy.ts

@@ -6,11 +6,13 @@ describe("Declaration", () => {
     cy.clearCookies();
   });
   afterEach(() => {
-    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false }).then((response) => { cy.log(`Clean endpoint: status=${response.status}, body=${JSON.stringify(response.body)}`); });
   });
 
   it("Doit compléter le parcours du simulateur jusqu'à la page de récapitulatif", () => {
     cy.loginWithKeycloak();
+    // Clean any leftover declarations (important for retry attempts)
+    cy.request({ method: "POST", url: "/apiv2/clean-test-user/declaration", failOnStatusCode: false });
 
     // Visiter la page de démarrage du simulateur
     cy.visit("/");