fix(e2e): stabilise submit mutation + campaign stats disclosure locator

- \`declaration.submit\`: replace the \`sql\`COALESCE(...)\`\` template with a
  straight select-then-update. The tagged-template form hung the submit
  mutation on the CI e2e env (compliance / declaration step 6 / fileUpload
  flows all timed out waiting for post-submit navigation). The new form
  is simpler and matches how the rest of the router reads + writes.
- Admin stats e2e: wait for the chart figure before opening the
  disclosure, and target the \`<summary>\` via CSS since Chromium's ARIA
  tree for \`<details>/<summary>\` varies and \`getByRole('button')\` was
  timing out.

Author: LucasCharrier

packages/app/src/e2e/admin-stats-campagne.e2e.ts

@@ -65,17 +65,17 @@ test.describe("admin campaign progression stats", () => {
 	test("accessible alternative table lists the same data", async ({ page }) => {
 		await page.goto("/admin/stats/campagne");
 
-		await page
-			.getByRole("group", { name: /^années à comparer/i })
-			.getByRole("checkbox", { name: "2024" })
-			.check()
-			.catch(() => {
-				/* already checked by default selection */
-			});
+		// Wait for the chart to be rendered — the table renders next to it only
+		// once the tRPC query resolves.
+		await expect(
+			page.getByRole("figure", { name: /courbe de progression cumulative/i }),
+		).toBeVisible();
 
+		// The table lives inside a <details> disclosure — use the summary text
+		// directly rather than a role match (varies across browsers).
 		await page
-			.getByRole("button", {
-				name: /consulter les données du graphique sous forme de tableau/i,
+			.locator("summary", {
+				hasText: /consulter les données du graphique sous forme de tableau/i,
 			})
 			.click();
 

packages/app/src/server/api/routers/__tests__/declaration.test.ts

@@ -268,18 +268,25 @@ describe("declarationRouter", () => {
 			);
 		});
 
-		it("sets submittedAt via COALESCE so resubmits preserve the first date", async () => {
-			const mockDb = createMockDb();
+		it("keeps the existing submittedAt when one is already present", async () => {
+			const firstSubmission = new Date("2024-01-15T09:00:00Z");
+			const mockDb = createMockDb([{ submittedAt: firstSubmission }]);
 			const caller = await createCaller(mockDb);
 
 			await caller.submit();
 
 			const call = mockSet.mock.calls[0]?.[0] as Record<string, unknown>;
-			expect(call).toHaveProperty("submittedAt");
-			// Drizzle `sql` tag produces an SQL object with a queryChunks array.
-			expect(call.submittedAt).toMatchObject({
-				queryChunks: expect.any(Array),
-			});
+			expect(call.submittedAt).toBe(firstSubmission);
+		});
+
+		it("stamps submittedAt with now when the row has never been submitted", async () => {
+			const mockDb = createMockDb([{ submittedAt: null }]);
+			const caller = await createCaller(mockDb);
+
+			await caller.submit();
+
+			const call = mockSet.mock.calls[0]?.[0] as Record<string, unknown>;
+			expect(call.submittedAt).toBeInstanceOf(Date);
 		});
 
 		it("throws when siret is missing", async () => {

packages/app/src/server/api/routers/declaration.ts

@@ -1,5 +1,5 @@
 import { TRPCError } from "@trpc/server";
-import { and, eq, isNull, sql } from "drizzle-orm";
+import { and, eq, isNull } from "drizzle-orm";
 import {
 	saveCompliancePathSchema,
 	updateEmployeeCategoriesSchema,
@@ -454,14 +454,20 @@ export const declarationRouter = createTRPCRouter({
 		const year = getCurrentYear();
 		const now = new Date();
 
+		// Preserve the very first submission date — resubmissions after
+		// corrections must not move the campaign progression curve.
+		const [existing] = await ctx.db
+			.select({ submittedAt: declarations.submittedAt })
+			.from(declarations)
+			.where(and(eq(declarations.siren, siren), eq(declarations.year, year)))
+			.limit(1);
+
 		await ctx.db
 			.update(declarations)
 			.set({
 				status: "submitted",
 				currentStep: 6,
-				// Preserve the very first submission date — resubmissions after
-				// corrections must not move the campaign progression curve.
-				submittedAt: sql`COALESCE(${declarations.submittedAt}, ${now})`,
+				submittedAt: existing?.submittedAt ?? now,
 				updatedAt: now,
 			})
 			.where(and(eq(declarations.siren, siren), eq(declarations.year, year)));