refactor(admin): drop Index and Valeur filters on /admin/declarations (#3274)

Author: LucasCharrier

packages/app/src/modules/admin/declarations/AdminDeclarationsPage.tsx

@@ -22,11 +22,6 @@ function DeclarationsContent() {
 		dateFrom: searchParams.get("dateFrom") ?? undefined,
 		dateTo: searchParams.get("dateTo") ?? undefined,
 		status: (searchParams.get("status") as "draft" | "submitted") || undefined,
-		index: searchParams.get("index")
-			? Number(searchParams.get("index"))
-			: undefined,
-		indexOperator:
-			(searchParams.get("indexOperator") as "gt" | "lt" | "eq") || undefined,
 		page: Number(searchParams.get("page") ?? "1"),
 		pageSize: Number(searchParams.get("pageSize") ?? String(DEFAULT_PAGE_SIZE)),
 		sortBy: (searchParams.get("sortBy") as SortColumn) ?? "createdAt",

packages/app/src/modules/admin/declarations/SearchForm.tsx

@@ -23,9 +23,6 @@ export function SearchForm() {
 				dateTo: searchParams.get("dateTo") ?? "",
 				status:
 					(searchParams.get("status") as "" | "draft" | "submitted") ?? "",
-				index: searchParams.get("index") ?? "",
-				indexOperator:
-					(searchParams.get("indexOperator") as "" | "gt" | "lt" | "eq") ?? "",
 			},
 		},
 	);
@@ -52,8 +49,6 @@ export function SearchForm() {
 			dateFrom: "",
 			dateTo: "",
 			status: "",
-			index: "",
-			indexOperator: "",
 		});
 		router.push("/admin/declarations");
 	}, [reset, router]);
@@ -144,42 +139,6 @@ export function SearchForm() {
 						</select>
 					</div>
 				</div>
-				<div className="fr-col-12 fr-col-md-3">
-					<div className="fr-grid-row fr-grid-row--gutters">
-						<div className="fr-col-6">
-							<div className="fr-select-group">
-								<label className="fr-label" htmlFor="search-index-op">
-									Index
-								</label>
-								<select
-									className="fr-select"
-									id="search-index-op"
-									{...register("indexOperator")}
-								>
-									<option value="">—</option>
-									<option value="eq">=</option>
-									<option value="gt">&ge;</option>
-									<option value="lt">&le;</option>
-								</select>
-							</div>
-						</div>
-						<div className="fr-col-6">
-							<div className="fr-input-group">
-								<label className="fr-label" htmlFor="search-index">
-									Valeur
-								</label>
-								<input
-									className="fr-input"
-									id="search-index"
-									max={100}
-									min={0}
-									type="number"
-									{...register("index")}
-								/>
-							</div>
-						</div>
-					</div>
-				</div>
 			</div>
 			<div className="fr-grid-row fr-grid-row--right fr-mt-2w">
 				<ul className="fr-btns-group fr-btns-group--inline">

packages/app/src/modules/admin/declarations/__tests__/SearchForm.test.tsx

@@ -29,8 +29,12 @@ describe("SearchForm", () => {
 		expect(screen.getByLabelText("Date de dépôt (du)")).toBeInTheDocument();
 		expect(screen.getByLabelText("Date de dépôt (au)")).toBeInTheDocument();
 		expect(screen.getByLabelText("Statut")).toBeInTheDocument();
-		expect(screen.getByLabelText("Index")).toBeInTheDocument();
-		expect(screen.getByLabelText("Valeur")).toBeInTheDocument();
+	});
+
+	it("does not render removed Index / Valeur filters", () => {
+		render(<SearchForm />);
+		expect(screen.queryByLabelText("Index")).not.toBeInTheDocument();
+		expect(screen.queryByLabelText("Valeur")).not.toBeInTheDocument();
 	});
 
 	it("renders search and reset buttons", () => {

packages/app/src/modules/admin/declarations/__tests__/schemas.test.ts

@@ -20,8 +20,6 @@ describe("searchDeclarationsSchema", () => {
 			year: "2024",
 			dateFrom: "2024-01-01",
 			dateTo: "2024-12-31",
-			index: "75",
-			indexOperator: "gt",
 			status: "submitted",
 			page: "2",
 			pageSize: "50",
@@ -35,8 +33,6 @@ describe("searchDeclarationsSchema", () => {
 			year: 2024,
 			dateFrom: "2024-01-01",
 			dateTo: "2024-12-31",
-			index: 75,
-			indexOperator: "gt",
 			status: "submitted",
 			page: 2,
 			pageSize: 50,

packages/app/src/modules/admin/declarations/schemas.ts

@@ -11,10 +11,6 @@ export const SORT_COLUMNS = [
 
 export type SortColumn = (typeof SORT_COLUMNS)[number];
 
-export const INDEX_OPERATORS = ["gt", "lt", "eq"] as const;
-
-export type IndexOperator = (typeof INDEX_OPERATORS)[number];
-
 export const DEFAULT_PAGE_SIZE = 20;
 
 export const searchDeclarationsSchema = z.object({
@@ -23,8 +19,6 @@ export const searchDeclarationsSchema = z.object({
 	year: z.coerce.number().int().min(2018).max(2100).optional(),
 	dateFrom: z.string().date().optional().or(z.literal("")),
 	dateTo: z.string().date().optional().or(z.literal("")),
-	index: z.coerce.number().int().min(0).max(100).optional(),
-	indexOperator: z.enum(INDEX_OPERATORS).optional(),
 	status: z.enum(["draft", "submitted"]).optional(),
 	page: z.coerce.number().int().min(1).default(1),
 	pageSize: z.coerce.number().int().min(10).max(100).default(DEFAULT_PAGE_SIZE),
@@ -43,8 +37,6 @@ export const searchDeclarationsFormSchema = z.object({
 	year: z.string().optional(),
 	dateFrom: z.string().optional(),
 	dateTo: z.string().optional(),
-	index: z.string().optional(),
-	indexOperator: z.enum(["", ...INDEX_OPERATORS]).optional(),
 	status: z.enum(["", "draft", "submitted"]).optional(),
 });
 

packages/app/src/server/api/routers/adminDeclarations.ts

@@ -7,7 +7,6 @@ import {
 	gte,
 	ilike,
 	lt,
-	lte,
 	or,
 	type SQL,
 } from "drizzle-orm";
@@ -75,21 +74,6 @@ export const adminDeclarationsRouter = createTRPCRouter({
 				filters.push(eq(declarations.status, input.status));
 			}
 
-			if (input.index !== undefined && input.indexOperator) {
-				const indexScore = declarations.remunerationScore;
-				switch (input.indexOperator) {
-					case "gt":
-						filters.push(gte(indexScore, input.index));
-						break;
-					case "lt":
-						filters.push(lte(indexScore, input.index));
-						break;
-					case "eq":
-						filters.push(eq(indexScore, input.index));
-						break;
-				}
-			}
-
 			const where = filters.length > 0 ? and(...filters) : undefined;
 			const orderDir = input.sortOrder === "asc" ? asc : desc;
 			const orderColumn = sortColumnMap[input.sortBy];