fix(unregister cron): key generation typo while previous refacto

Author: devthejo

pkg/config/strategy-config.go

@@ -11,7 +11,7 @@ import (
 	"k8s.io/klog/v2"
 )
 
-func CreateStrategyConfig(configurable *Configurable) *StrategyConfig {
+func GetKey(configurable *Configurable) string {
 	workloadName := configurable.GetName()
 
 	if strings.HasPrefix(workloadName, VpaPrefix) {
@@ -21,6 +21,14 @@ func CreateStrategyConfig(configurable *Configurable) *StrategyConfig {
 	}
 
 	key := fmt.Sprintf("%s/%s", configurable.GetNamespace(), workloadName)
+
+	return key
+}
+
+func CreateStrategyConfig(configurable *Configurable) *StrategyConfig {
+
+	key := GetKey(configurable)
+
 	cfg := &StrategyConfig{
 		Key: key,
 		LoadCfg: &LoadCfg{

pkg/watcher/watch-vpas.go

@@ -2,7 +2,6 @@ package watcher
 
 import (
 	"context"
-	"fmt"
 	"math/rand"
 	"sync"
 	"time"
@@ -55,7 +54,10 @@ func WatchVPAs(ctx context.Context, kubeClients *client.KubeClients) {
 					klog.Error("Could not cast to VPA object")
 					return
 				}
-				key := fmt.Sprintf("%s/%s", vpa.Namespace, vpa.Name)
+
+				configurable := config.CreateConfigurable(vpa)
+				key := config.GetKey(configurable)
+
 				if entryID, exists := cronJobs[key]; exists {
 					CronScheduler.Remove(entryID)
 				}