Skip to content

What about handling rfc6749 Error Response? #219

Open
@Cellard

Description

@Cellard

Issue / Motivation:

While requesting for authorization using any of response_type methods server may responds (redirect back) with error.

For response_type=code see https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1
For response_type=token see https://datatracker.ietf.org/doc/html/rfc6749#section-4.2.2.1

Also, then requesting for access_token with any grant_type server may respond with an error. See https://datatracker.ietf.org/doc/html/rfc6749#section-5.2

Expected behaviour:

Socialite Manager should examine callback request and throw an exception with error and its description (just like InvalidStateException does).

Socialite Manager should examine token response and throw an exception with error and its description.

Actual behavior:

Socialite Manager tries to exchange code to access_token although code is missing in request. So it got an unsurprising error response.

Socialite Manager tries to parse access_token form token response even access_token is missing. Then it makes request to Resource Owner with empty string in Authorisation header.

Steps to reproduce the behavior:

Try to authorize to any (rfc6749 compliant) server with response_type=foobar and you will get unsupported_response_type error.

Or request for scope=foobar (that is not supported by the server). You will get invalid_scope error in response.

Proposed solution:

Im ready to make a pr. If you resolve this issue has sense.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions