Skip to content

Commit e57fad5

Browse files
Fix review findings #1
1 parent 9c3b0dc commit e57fad5

File tree

4 files changed

+0
-20
lines changed

4 files changed

+0
-20
lines changed

Diff for: src/Utils/BundleChecker.cpp

-7
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,4 @@ namespace sua {
2525
return updateBundleVer != installer->getBundleVersion();
2626
}
2727

28-
bool BundleChecker::isBundleVersionConsistent(const std::string & declaredVersion,
29-
std::shared_ptr<IRaucInstaller> installer,
30-
const std::string & bundlePath)
31-
{
32-
return declaredVersion == installer->getBundleVersion(bundlePath);
33-
}
34-
3528
} // namespace sua

Diff for: src/Utils/BundleChecker.h

-4
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@ namespace sua {
2525
public:
2626
bool isUpdateBundleVersionDifferent(const std::string & updateBundleVer,
2727
std::shared_ptr<IRaucInstaller> installer) override;
28-
29-
bool isBundleVersionConsistent(const std::string & declaredVersion,
30-
std::shared_ptr<IRaucInstaller> installer,
31-
const std::string & bundlePath) override;
3228
};
3329

3430
} // namespace sua

Diff for: src/Utils/IBundleChecker.h

-4
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ namespace sua {
2929

3030
virtual bool isUpdateBundleVersionDifferent(const std::string & updateBundleVer,
3131
std::shared_ptr<IRaucInstaller> installer) = 0;
32-
33-
virtual bool isBundleVersionConsistent(const std::string & declaredVersion,
34-
std::shared_ptr<IRaucInstaller> installer,
35-
const std::string & bundlePath) = 0;
3632
};
3733

3834
} // namespace sua

Diff for: utest/MockBundleChecker.h

-5
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ class MockBundleChecker : public sua::IBundleChecker {
2626
public:
2727
MOCK_METHOD(bool, isUpdateBundleVersionDifferent,
2828
(const std::string & updateBundleVer, std::shared_ptr<sua::IRaucInstaller> installer), (override));
29-
30-
MOCK_METHOD(bool, isBundleVersionConsistent,
31-
(const std::string & declaredVersion,
32-
std::shared_ptr<sua::IRaucInstaller> installer,
33-
const std::string & bundlePath), (override));
3429
};
3530

3631
#endif

0 commit comments

Comments
 (0)