fix: A serious performance issue #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making both the setbg script of hyprv_util and waybar as exec will make them always start another process and thus, that will lead to reduced perfomance Changing them to exec-once will not make another process start, and fret not, my testing shows that changing set custom backgrouds still work and changing hyprv versions also work
jonasvq
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making both the setbg script of hyprv_util and waybar as
execwill make them always start another process and thus, that will lead to reduced performanceChanging them to
exec-oncewill not make another process start, and fret not, my testing shows that changing set custom backgrounds still work and changing hyprv versions also work.If there's any issues caused by this that I am not aware of, please let me know so I can make the needed changes before this pull request can be merged!