DATAGO-108479: Forgot about adding coverage for "Name does not resolve" scenario.

Author: moodiRealist

service/application/src/main/java/com/solace/maas/ep/event/management/agent/command/SempGetCommandManager.java

@@ -66,15 +66,15 @@ public void execute(Command command, SempApiProvider sempApiProvider) {
             if (SempEntityType.solaceClientProfileName.name().equals(entityType) &&
                     isResourceNotFoundError(e)) {
                 handleClientProfileNotFound(command);
-            } else if (isConnectTimeoutError(e)) {
+            } else if (isConnectTimeoutError(e) || isNameResolutionError(e)) {
                 log.warn(SEMP_COMMAND_NOT_EXECUTED_SUCCESSFULLY, supportedSempCommand(), e);
                 setCommandError(command, e);
             } else {
                 log.error(SEMP_COMMAND_NOT_EXECUTED_SUCCESSFULLY, supportedSempCommand(), e);
                 setCommandError(command, e);
             }
         } catch (Exception e) {
-            if (isConnectTimeoutError(e)) {
+            if (isConnectTimeoutError(e) || isNameResolutionError(e)) {
                 log.warn(SEMP_COMMAND_NOT_EXECUTED_SUCCESSFULLY, supportedSempCommand(), e);
                 setCommandError(command, e);
             } else {
@@ -115,6 +115,32 @@ private boolean isConnectTimeoutError(Exception e) {
         return false;
     }
 
+    /**
+     * Checks if the exception represents a name resolution error.
+     * This method examines the exception message and cause chain for DNS resolution failures.
+     */
+    private boolean isNameResolutionError(Exception e) {
+        // Check the exception message for name resolution indicators
+        String message = e.getMessage();
+        if (message != null && message.contains("Name does not resolve")) {
+            return true;
+        }
+
+        // Check the cause chain for UnknownHostException with name resolution errors
+        Throwable cause = e.getCause();
+        while (cause != null) {
+            if (cause instanceof java.net.UnknownHostException) {
+                String causeMessage = cause.getMessage();
+                if (causeMessage != null && causeMessage.contains("Name does not resolve")) {
+                    return true;
+                }
+            }
+            cause = cause.getCause();
+        }
+
+        return false;
+    }
+
     private void handleClientProfileNotFound(Command command) {
         String resourceName = extractClientProfileName(command);
         String errorMessage = String.format("Named client profile not found on the event broker: %s", resourceName);

service/application/src/test/java/com/solace/maas/ep/event/management/agent/commandManager/SempGetCommandManagerTest.java

@@ -21,6 +21,7 @@
 
 import java.io.IOException;
 import java.net.SocketTimeoutException;
+import java.net.UnknownHostException;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -289,6 +290,50 @@ void withGeneralExceptionConnectTimeout() throws ApiException {
         executeTestWithException(generalException);
     }
 
+    @Test
+    void withNameResolutionApiException() throws ApiException {
+        // Create an ApiException with UnknownHostException as cause containing "Name does not resolve"
+        UnknownHostException nameResolutionException = new UnknownHostException("msg-solace-test.lcag-cmlz-n.lhgroup.de: Name does not resolve");
+        ApiException apiException = new ApiException(nameResolutionException);
+
+        executeTestWithException(apiException);
+    }
+
+    @Test
+    void withNameResolutionExceptionMessage() throws ApiException {
+        // Create an ApiException with "Name does not resolve" in the message
+        ApiException apiException = new ApiException("java.net.UnknownHostException: msg-solace-test.lcag-cmlz-n.lhgroup.de: Name does not resolve");
+
+        executeTestWithException(apiException);
+    }
+
+    @Test
+    void withNestedNameResolutionException() throws ApiException {
+        // Create nested exception with UnknownHostException deep in the cause chain
+        UnknownHostException nameResolutionException = new UnknownHostException("host.example.com: Name does not resolve");
+        RuntimeException wrapperException = new RuntimeException("Wrapper exception", nameResolutionException);
+        ApiException apiException = new ApiException(wrapperException);
+
+        executeTestWithException(apiException);
+    }
+
+    @Test
+    void withNonNameResolutionUnknownHostException() throws ApiException {
+        // Create UnknownHostException with different message (not name resolution)
+        UnknownHostException unknownHostException = new UnknownHostException("No route to host");
+        ApiException apiException = new ApiException(unknownHostException);
+
+        executeTestWithException(apiException);
+    }
+
+    @Test
+    void withGeneralExceptionNameResolution() throws ApiException {
+        // Create a general Exception (not ApiException) with name resolution error
+        RuntimeException generalException = new RuntimeException("Connection failed: Name does not resolve");
+
+        executeTestWithException(generalException);
+    }
+
     private void executeTestWithException(Exception exception) throws ApiException {
         ClientProfileApi clientProfileApi = Mockito.mock(ClientProfileApi.class);
         when(sempApiProvider.getClientProfileApi()).thenReturn(clientProfileApi);