Skip to content

Commit d1a9d70

Browse files
committed
fix: Update GitHub Actions workflows to use read-only credentials for package access
1 parent 5642bfb commit d1a9d70

File tree

3 files changed

+18
-12
lines changed

3 files changed

+18
-12
lines changed

.github/workflows/release.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ jobs:
5353
jwtGithubAudience: https://github.com/${{ github.repository_owner }}
5454
exportToken: true
5555
secrets:
56-
secret/data/tools/githubactions RE_BOT_PACKAGES_READ_WRITE_CLASSIC_USER | GITHUB_USER ;
57-
secret/data/tools/githubactions RE_BOT_PACKAGES_READ_WRITE_CLASSIC_TOKEN | GITHUB_TOKEN ;
56+
secret/data/tools/githubactions RE_BOT_PACKAGES_READ_ONLY_CLASSIC_USER | PACKAGES_READ_USER ;
57+
secret/data/tools/githubactions RE_BOT_PACKAGES_READ_ONLY_CLASSIC_TOKEN | PACKAGES_READ_TOKEN ;
5858
secret/data/tools/githubactions MAVEN_GPG_KEY_PASSPHRASE | MAVEN_GPG_KEY_PASSPHRASE ;
5959
secret/data/tools/githubactions MAVEN_GPG_KEY | MAVEN_GPG_KEY ;
6060
secret/data/tools/githubactions MAVEN_USERNAME | MAVEN_USERNAME ;
@@ -91,7 +91,7 @@ jobs:
9191
9292
- name: Pre-Release Check - Version
9393
env:
94-
GITHUB_TOKEN: ${{ steps.secrets.outputs.GITHUB_TOKEN }}
94+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
9595
run: |
9696
gh api --method GET /repos/${{github.repository}}/releases -f sort=updated -f direction=asc > releases.json
9797
release_version_exists=$(jq -r --arg RELEASE_VERSION ${{ inputs.release_version }} '.[].name|select(.|test($RELEASE_VERSION))' releases.json)
@@ -128,13 +128,17 @@ jobs:
128128
129129
- name: Deploy Artifacts (GH Packages)
130130
env:
131-
GITHUB_TOKEN: ${{ steps.secrets.outputs.GITHUB_TOKEN }}
131+
PACKAGES_READ_USER: ${{ steps.secrets.outputs.PACKAGES_READ_USER }}
132+
PACKAGES_READ_TOKEN: ${{ steps.secrets.outputs.PACKAGES_READ_TOKEN }}
133+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
132134
run: >-
133135
mvn deploy -B -DreleaseTarget=github -s maven/settings.xml $SKIP_FLAGS_ALL_TESTS
134136
135137
- name: Deploy Artifacts (Maven Central)
136138
env:
137-
GITHUB_TOKEN: ${{ steps.secrets.outputs.GITHUB_TOKEN }}
139+
PACKAGES_READ_USER: ${{ steps.secrets.outputs.PACKAGES_READ_USER }}
140+
PACKAGES_READ_TOKEN: ${{ steps.secrets.outputs.PACKAGES_READ_TOKEN }}
141+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
138142
run: >-
139143
mvn deploy -B -DreleaseTarget=central -s maven/settings.xml $SKIP_FLAGS_ALL_TESTS
140144

.github/workflows/test-release-auth.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ jobs:
2626
jwtGithubAudience: https://github.com/${{ github.repository_owner }}
2727
exportToken: true
2828
secrets: |
29-
secret/data/tools/githubactions RE_BOT_PACKAGES_READ_WRITE_CLASSIC_USER | GITHUB_USER ;
30-
secret/data/tools/githubactions RE_BOT_PACKAGES_READ_WRITE_CLASSIC_TOKEN | GITHUB_TOKEN
29+
secret/data/tools/githubactions RE_BOT_PACKAGES_READ_ONLY_CLASSIC_USER | PACKAGES_READ_USER ;
30+
secret/data/tools/githubactions RE_BOT_PACKAGES_READ_ONLY_CLASSIC_TOKEN | PACKAGES_READ_TOKEN
3131
3232
- name: Warn of Vault Login Failure
3333
if: steps.secrets.outcome != 'success'
@@ -42,13 +42,15 @@ jobs:
4242

4343
- name: Test Dependency Resolution
4444
env:
45-
GITHUB_TOKEN: ${{ steps.secrets.outputs.GITHUB_TOKEN }}
45+
PACKAGES_READ_USER: ${{ steps.secrets.outputs.PACKAGES_READ_USER }}
46+
PACKAGES_READ_TOKEN: ${{ steps.secrets.outputs.PACKAGES_READ_TOKEN }}
4647
run: |
47-
echo "Testing if we can download dependencies from SolaceDev..."
48+
echo "Testing if we can download dependencies from SolaceDev using read-only token..."
4849
mvn dependency:resolve -B -s maven/settings.xml
4950
5051
- name: Test Build (Verify - No Deploy)
5152
env:
52-
GITHUB_TOKEN: ${{ steps.secrets.outputs.GITHUB_TOKEN }}
53+
PACKAGES_READ_USER: ${{ steps.secrets.outputs.PACKAGES_READ_USER }}
54+
PACKAGES_READ_TOKEN: ${{ steps.secrets.outputs.PACKAGES_READ_TOKEN }}
5355
run: >-
5456
mvn verify -B -s maven/settings.xml -Dcheckstyle.skip -Dpmd.skip -Dcpd.skip -Dfindbugs.skip -Dspotbugs.skip -DskipTests=true

maven/settings.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
<servers>
3737
<server>
3838
<id>github-solacedev</id>
39-
<username>${env.GITHUB_USER}</username>
40-
<password>${env.GITHUB_TOKEN}</password>
39+
<username>${env.PACKAGES_READ_USER}</username>
40+
<password>${env.PACKAGES_READ_TOKEN}</password>
4141
</server>
4242
<server>
4343
<id>github</id>

0 commit comments

Comments
 (0)