test(commitlint): add negative case

Author: kguzek

src/cli/install-commitlint.ts

@@ -13,7 +13,7 @@ const packageJson = new PackageJson();
 export const installCommitLint = async () => {
   await installHusky();
 
-  await packageJson.install("@commitlint/cli", { version: "20", dev: true });
+  await packageJson.install("@commitlint/cli", { version: "^20", dev: true });
 
   await writeFile(
     path.join(root, ".husky/commit-msg"),

tests/integration.test.ts

@@ -19,6 +19,7 @@ const expectGeneratedConfigToBeFormatted = async ({
     appPath,
     generatedFilesThatExist,
   );
+  expect(prettierCheckResult.skipped, prettierCheckResult.output).toBe(false);
   expect(prettierCheckResult.success, prettierCheckResult.output).toBe(true);
 };
 
@@ -40,6 +41,30 @@ const expectCommitlintHookToAllowMessage = async ({
   expect(commitResult.success, commitResult.output).toBe(true);
 };
 
+const expectCommitlintHookToRejectMessage = async ({
+  env,
+  appPath,
+  message,
+}: {
+  env: TestEnvironment;
+  appPath: string;
+  message: string;
+}) => {
+  env.writeFile(
+    appPath,
+    "commitlint-hook-test-invalid.txt",
+    `commitlint hook invalid test ${Date.now()}\n`,
+  );
+  const commitResult = await env.commitWithMessage(appPath, message);
+  expect(commitResult.success, commitResult.output).toBe(false);
+  expect(
+    /subject-empty|type-empty|commit-msg script failed/i.test(
+      commitResult.output,
+    ),
+    commitResult.output,
+  ).toBe(true);
+};
+
 describe("Next.js Integration Tests", () => {
   let testEnv: TestEnvironment;
   const packageManager = getCurrentPackageManager();
@@ -265,7 +290,6 @@ describe("Commitlint Integration Tests", () => {
     };
     packageJson.scripts = packageJson.scripts ?? {};
     packageJson.scripts.test = packageJson.scripts.test ?? "true";
-    (packageJson as { type?: string }).type = "module";
     env.writeFile(
       appPath,
       "package.json",
@@ -277,5 +301,11 @@ describe("Commitlint Integration Tests", () => {
       appPath,
       message: "chore: test commit",
     });
+
+    await expectCommitlintHookToRejectMessage({
+      env,
+      appPath,
+      message: "invalid commit message",
+    });
   });
 });

tests/utils/test-environment.ts

@@ -416,14 +416,6 @@ export class TestEnvironment {
       packageJson.dependencies?.prettier != null ||
       packageJson.devDependencies?.prettier != null;
 
-    if (!hasPrettier) {
-      return {
-        success: true,
-        output: "Skipped prettier check: prettier is not installed.",
-        skipped: true,
-      };
-    }
-
     if (paths.length === 0) {
       return {
         success: true,
@@ -432,12 +424,20 @@ export class TestEnvironment {
       };
     }
 
+    const prettierCommand: keyof PackageManagerConfig = hasPrettier
+      ? "localExecute"
+      : "downloadExecute";
+
+    const prettierArgs = hasPrettier
+      ? ["prettier", "--check", ...paths]
+      : ["prettier", "--check", ...paths];
+
     try {
       const { stdout, stderr } = await this.execute({
-        command: "localExecute",
-        args: ["prettier", "--check", ...paths],
+        command: prettierCommand,
+        args: prettierArgs,
         cwd: appPath,
-        label: "prettier-check",
+        label: hasPrettier ? "prettier-check" : "prettier-check-dlx",
       });
       return { success: true, output: stdout + stderr, skipped: false };
     } catch (error: any) {