JS-811 SQ issues on Java code (#5557)

Author: zglicz

sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarning.java

@@ -37,6 +37,7 @@ public class NodeDeprecationWarning {
   static final Version MIN_SUPPORTED_NODE_VERSION;
   private static final List<String> RECOMMENDED_NODE_VERSIONS;
   public static final Version RECOMMENDED_NODE_VERSION;
+  private final AnalysisWarningsWrapper analysisWarnings;
 
   static {
     Properties props = loadProperties(NODE_PROPERTIES_FILE);
@@ -49,6 +50,10 @@ public class NodeDeprecationWarning {
     );
   }
 
+  public NodeDeprecationWarning(AnalysisWarningsWrapper analysisWarnings) {
+    this.analysisWarnings = analysisWarnings;
+  }
+
   static Properties loadProperties(String resourceName) {
     try (InputStream inputStream = NodeDeprecationWarning.class.getResourceAsStream(resourceName)) {
       return loadProperties(inputStream);
@@ -67,12 +72,6 @@ static Properties loadProperties(@Nullable InputStream inputStream) throws IOExc
     }
   }
 
-  private final AnalysisWarningsWrapper analysisWarnings;
-
-  public NodeDeprecationWarning(AnalysisWarningsWrapper analysisWarnings) {
-    this.analysisWarnings = analysisWarnings;
-  }
-
   void logNodeDeprecation(Version actualNodeVersion) {
     if (!actualNodeVersion.isGreaterThanOrEqual(RECOMMENDED_NODE_VERSION)) {
       String msg = String.format(

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2310.html

@@ -1,4 +1,3 @@
-<p>This rule is deprecated; use {rule:javascript:S127} instead.</p>
 <h2>Why is this an issue?</h2>
 <p>Loop counters, such as variables used to track the iteration count in loops, should not be assigned from within the loop body to avoid unexpected
 behavior and bugs. It can inadvertently lead to an infinite loop or make the loop behavior more complex and harder to reason about.</p>

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2310.json

@@ -1,18 +1,12 @@
 {
   "title": "Loop counters should not be assigned within the loop body",
   "type": "CODE_SMELL",
-  "status": "deprecated",
+  "status": "ready",
   "remediation": {
     "func": "Constant/Issue",
     "constantCost": "5min"
   },
   "tags": [],
-  "extra": {
-    "replacementRules": [
-      "RSPEC-127"
-    ],
-    "legacyKeys": []
-  },
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2310",
   "sqKey": "S2310",

sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/JavaScriptProfilesDefinitionTest.java

@@ -86,7 +86,8 @@ public void register(RegistrarContext registrarContext) {
           }
         },
       }
-    ).define(context);
+    )
+      .define(context);
   }
 
   @Test
@@ -103,7 +104,7 @@ void sonar_way_js() {
       .containsOnly(CheckList.JS_REPOSITORY_KEY, "additionalRepository");
     assertThat(profile.rules().size()).isGreaterThan(100);
 
-    assertThat(deprecatedRulesInProfile(profile, deprecatedJsRules)).hasSize(1);
+    assertThat(deprecatedRulesInProfile(profile, deprecatedJsRules)).isEmpty();
   }
 
   private List<String> deprecatedRulesInProfile(
@@ -128,12 +129,12 @@ void sonar_way_ts() {
     assertThat(profile.language()).isEqualTo(TypeScriptLanguage.KEY);
     assertThat(profile.name()).isEqualTo(JavaScriptProfilesDefinition.SONAR_WAY);
     assertThat(profile.rules()).extracting("repoKey").containsOnly(CheckList.TS_REPOSITORY_KEY);
-    assertThat(profile.rules().size()).isGreaterThan(100);
+    assertThat(profile.rules()).hasSizeGreaterThan(100);
     assertThat(profile.rules())
       .extracting(BuiltInQualityProfilesDefinition.BuiltInActiveRule::ruleKey)
       .contains("S5122");
 
-    assertThat(deprecatedRulesInProfile(profile, deprecatedTsRules)).hasSize(1);
+    assertThat(deprecatedRulesInProfile(profile, deprecatedTsRules)).isEmpty();
   }
 
   @Test