JS-654 Don't use maven profile for ITS (#5224)

Author: vdiez

.cirrus.yml

@@ -126,7 +126,7 @@ plugin_qa_body: &PLUGIN_QA_BODY
   qa_script:
     - source cirrus-env QA
     - source set_maven_build_version $BUILD_NUMBER
-    - mvn -f its/plugin/pom.xml -Dsonar.runtimeVersion=${SQ_VERSION} ${MVN_TEST} -B -e -V verify surefire-report:report
+    - mvn -f its/plugin/pom.xml -DskipTests=false -Dsonar.runtimeVersion=${SQ_VERSION} ${MVN_TEST} -B -e -V verify surefire-report:report
 
 plugin_qa_body_monthly: &PLUGIN_QA_BODY_MONTHLY
   depends_on:
@@ -142,7 +142,7 @@ plugin_qa_body_monthly: &PLUGIN_QA_BODY_MONTHLY
   qa_script:
     - source cirrus-env QA
     - source set_maven_build_version $BUILD_NUMBER
-    - mvn -f its/plugin/pom.xml -Dsonar.runtimeVersion=${SQ_VERSION} ${MVN_TEST} -B -e -V verify surefire-report:report
+    - mvn -f its/plugin/pom.xml -DskipTests=false -Dsonar.runtimeVersion=${SQ_VERSION} ${MVN_TEST} -B -e -V verify surefire-report:report
 
 build_task:
   eks_container:
@@ -287,7 +287,7 @@ plugin_qa_win_task:
     - source /c/buildTools-docker/bin/set_maven_build_version $BUILD_NUMBER
     # building the custom plugin required for the further tests
     - mvn clean package -f its/plugin/plugins/pom.xml
-    - mvn test -f its/plugin/tests/pom.xml -Dsonar.runtimeVersion=${SQ_VERSION} "-Dtest=${TEST}" -B -e -V surefire-report:report
+    - mvn test -f its/plugin/tests/pom.xml -DskipTests=false -Dsonar.runtimeVersion=${SQ_VERSION} "-Dtest=${TEST}" -B -e -V surefire-report:report
 
 # Plugin QA for Windows is split into 3 parts to make it faster
 plugin_qa_win_sonarlint_task:
@@ -303,7 +303,7 @@ plugin_qa_win_sonarlint_task:
   qa_script:
     - source /c/buildTools-docker/bin/cirrus-env QA
     - source /c/buildTools-docker/bin/set_maven_build_version $BUILD_NUMBER
-    - mvn test -f its/plugin/sonarlint-tests/pom.xml -Dsonar.runtimeVersion=${SQ_VERSION} -B -e -V surefire-report:report
+    - mvn test -f its/plugin/sonarlint-tests/pom.xml -DskipTests=false -Dsonar.runtimeVersion=${SQ_VERSION} -B -e -V surefire-report:report
 
 js_ts_ruling_task:
   depends_on:
@@ -410,7 +410,7 @@ css_ruling_task:
     - source cirrus-env QA
     - source set_maven_build_version $BUILD_NUMBER
     - cd its/ruling
-    - mvn test -Dtest=CssRulingTest -Dsonar.runtimeVersion=LATEST_RELEASE -Dmaven.test.redirectTestOutputToFile=false -Djunit.jupiter.execution.parallel.config.dynamic.factor=1 -B -e -V
+    - mvn test -DskipTests=false -Dtest=CssRulingTest -Dsonar.runtimeVersion=LATEST_RELEASE -Dmaven.test.redirectTestOutputToFile=false -Djunit.jupiter.execution.parallel.config.dynamic.factor=1 -B -e -V
   on_failure:
     diff_artifacts:
       path: '**/target/actual/**/*'

its/plugin/plugins/eslint-custom-rules-plugin/pom.xml

@@ -63,4 +63,9 @@
     </plugins>
   </build>
 
+  <properties>
+    <!-- sonar scanner properties -->
+    <sonar.sources>src/main</sonar.sources>
+    <sonar.tests/>
+  </properties>
 </project>

its/plugin/sonarlint-tests/pom.xml

@@ -13,6 +13,9 @@
 
   <properties>
     <surefire.argLine>-server</surefire.argLine>
+    <!-- sonar scanner properties -->
+    <sonar.sources/>
+    <sonar.tests>src/test</sonar.tests>
   </properties>
 
   <!--

its/plugin/tests/pom.xml

@@ -13,6 +13,8 @@
 
   <properties>
     <surefire.argLine>-server</surefire.argLine>
+    <sonar.sources/>
+    <sonar.tests>src/test</sonar.tests>
   </properties>
 
   <dependencies>

its/pom.xml

@@ -56,5 +56,14 @@
       </plugin>
     </plugins>
   </build>
+  <properties>
+    <maven.deploy.skip>true</maven.deploy.skip>
+    <skipTests>true</skipTests>
+    <!-- sonar scanner properties -->
+    <sonar.sources>src/main</sonar.sources>
+    <sonar.tests>src/test</sonar.tests>
+    <sonar.javascript.lcov.reportPaths/>
+    <sonar.typescript.tsconfigPath/>
+  </properties>
 
 </project>

its/ruling/pom.xml

@@ -19,6 +19,8 @@
 
   <properties>
     <surefire.argLine>-server -Xmx512m</surefire.argLine>
+    <sonar.sources/>
+    <sonar.tests>src/test</sonar.tests>
   </properties>
 
   <dependencies>

pom.xml

@@ -59,9 +59,7 @@
   <modules>
     <module>maven-plugins</module>
     <module>sonar-plugin</module>
-    <!--
-      its module is added via profile below
-    -->
+    <module>its</module>
   </modules>
 
   <scm>
@@ -342,15 +340,4 @@
       </plugins>
     </pluginManagement>
   </build>
-
-  <profiles>
-    <profile>
-      <id>its</id>
-      <modules>
-        <module>its</module>
-      </modules>
-    </profile>
-  </profiles>
-
-
 </project>