SONARCS-579 Fail the analysis when custom Roslyn rules are enabled and MSBuild 12 is used

Author: dbolkensteyn

src/main/java/org/sonar/plugins/csharp/CSharpSensor.java

@@ -119,6 +119,11 @@ private void analyze(boolean includeRules) {
       LOG.warn("*                Use MSBuild 14 to get the best analysis results                 *");
       LOG.warn("* The use of MSBuild 12 or the sonar-runner to analyze C# projects is DEPRECATED *");
       LOG.warn("**********************************************************************************");
+
+      ImmutableMultimap<String, ActiveRule> activeRoslynRulesByPartialRepoKey = RoslynProfileExporter.activeRoslynRulesByPartialRepoKey(ruleProfile.getActiveRules());
+      if (activeRoslynRulesByPartialRepoKey.keySet().size() > 1) {
+        throw new IllegalArgumentException("Custom and 3rd party Roslyn analyzers are only by MSBuild 14. Either use MSBuild 14, or disable the custom/3rd party Roslyn analyzers in your quality profile.");
+      }
     }
 
     String analysisSettings = analysisSettings(true, settings.getBoolean("sonar.cs.ignoreHeaderComments"), includeRules, ruleProfile, filesToAnalyze());

src/test/java/org/sonar/plugins/csharp/CSharpSensorTest.java

@@ -22,8 +22,10 @@
 import com.google.common.base.Charsets;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Lists;
 import com.google.common.io.Files;
 import java.io.File;
+import java.util.List;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
@@ -88,6 +90,7 @@ public class CSharpSensorTest {
   private Issue issue5;
   private ActiveRule parametersActiveRule;
   private ActiveRule customRoslynActiveRule;
+  private List<ActiveRule> allEnabledRules = Lists.newArrayList();
 
   @Test
   public void shouldExecuteOnProject() {
@@ -183,7 +186,9 @@ public void init() {
 
     RulesProfile rulesProfile = mock(RulesProfile.class);
     when(rulesProfile.getActiveRulesByRepository("csharpsquid")).thenReturn(ImmutableList.of(templateActiveRule, parametersActiveRule));
-    when(rulesProfile.getActiveRules()).thenReturn(ImmutableList.of(templateActiveRule, parametersActiveRule, customRoslynActiveRule));
+    allEnabledRules.add(templateActiveRule);
+    allEnabledRules.add(parametersActiveRule);
+    when(rulesProfile.getActiveRules()).thenReturn(allEnabledRules);
 
     settings = mock(Settings.class);
     sensor =
@@ -196,6 +201,10 @@ public void init() {
     context = mock(SensorContext.class);
   }
 
+  private void enableCustomRoslynRules() {
+    allEnabledRules.add(customRoslynActiveRule);
+  }
+
   @Test
   public void metrics() {
     sensor.analyse(project, context);
@@ -271,6 +280,8 @@ public void escapesAnalysisInput() throws Exception {
 
   @Test
   public void roslynReportIsProcessed() {
+    enableCustomRoslynRules();
+
     when(settings.getString("sonar.cs.roslyn.reportFilePath")).thenReturn(new File("src/test/resources/CSharpSensorTest/roslyn-report.json").getAbsolutePath());
     sensor.analyse(project, context);
 
@@ -321,6 +332,8 @@ public void roslynEmptyReportShouldNotFail() {
 
   @Test
   public void failWithDuplicateRuleKey() {
+    enableCustomRoslynRules();
+
     String ruleKey = parametersActiveRule.getRuleKey();
     when(customRoslynActiveRule.getRuleKey()).thenReturn(ruleKey);
 
@@ -331,4 +344,13 @@ public void failWithDuplicateRuleKey() {
     sensor.analyse(project, context);
   }
 
+  @Test
+  public void failWithCustomRoslynRulesAndMSBuild12() {
+    enableCustomRoslynRules();
+    when(settings.getString("sonar.cs.roslyn.reportFilePath")).thenReturn(null);
+
+    thrown.expectMessage("Custom and 3rd party Roslyn analyzers are only by MSBuild 14. Either use MSBuild 14, or disable the custom/3rd party Roslyn analyzers in your quality profile.");
+    sensor.analyse(project, context);
+  }
+
 }