Skip to content

Refactor ThrowsOrReturnsNull from SonarAnalyzer.CSharp/Extensions/MethodDeclarationSyntaxExtensions.cs #5907

Open
@mary-georgiou-sonarsource

Description

ThrowsOrReturnsNull iterates the whole tree couple of times - there might be a way to optimize it.

Additionally as mentioned in a comment int the method "For simplicity this returns true for any method which contains a NullLiteralExpression but this could be a source of FNs".
This claim should be checked as it can be the source of FNs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type: CleanupImprove and cleanup code base

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions