Skip to content

Commit 8c05b39

Browse files
jonas-wielage-sonarsourcejonas-wielage-sonarsource
authored
SONARGO-325 Fix discrepancies between MQR and severity for Go rules (#94)
1 parent d7d56cc commit 8c05b39

File tree

71 files changed

+83
-80
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+83
-80
lines changed

‎.github/workflows/release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ jobs:
1717
with:
1818
publishToBinaries: true
1919
mavenCentralSync: true
20-
slackChannel: squad-jvm-notifs
20+
slackChannel: squad-security-cloud-notifs

‎build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ subprojects {
176176
useInMemoryPgpKeys(signingKeyId, signingKey, signingPassword)
177177
required {
178178
def branch = System.getenv()["CIRRUS_BRANCH"]
179-
return (branch == 'master' || branch ==~ 'branch-[\\d.]+') &&
179+
return (branch == 'master' || branch ==~ 'branch-.+') &&
180180
gradle.taskGraph.hasTask(":artifactoryPublish")
181181
}
182182
sign publishing.publications
@@ -186,7 +186,7 @@ subprojects {
186186
onlyIf {
187187
def branch = System.getenv()["CIRRUS_BRANCH"]
188188
return !artifactoryPublish.skip &&
189-
(branch == 'master' || branch ==~ 'branch-[\\d.]+') &&
189+
(branch == 'master' || branch ==~ 'branch-.+') &&
190190
gradle.taskGraph.hasTask(":artifactoryPublish")
191191
}
192192
}

‎gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
group=org.sonarsource.slang
2-
version=1.18.0-SNAPSHOT
2+
version=1.18.1-SNAPSHOT
33
description=Code Analyzer for Go
44
projectTitle=Go
55
org.gradle.jvmargs=-XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx1024m

‎its/plugin/src/test/java/org/sonarsource/slang/CoverageTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎its/plugin/src/test/java/org/sonarsource/slang/DuplicationsTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎its/plugin/src/test/java/org/sonarsource/slang/ExternalReportTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎its/plugin/src/test/java/org/sonarsource/slang/MeasuresTest.java

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or
@@ -35,13 +35,6 @@ public void go_measures() {
3535
assertThat(getMeasureAsInt(componentKey, "ncloc")).isEqualTo(41);
3636
assertThat(getMeasureAsInt(componentKey, "comment_lines")).isEqualTo(2);
3737

38-
assertThat(getMeasure(componentKey, "ncloc_data").getValue())
39-
.isEqualTo("1=1;3=1;4=1;5=1;6=1;7=1;8=1;10=1;11=1;12=1;13=1;14=1;16=1;17=1;18=1;20=1;21=1;22=1;23=1;24=1;25=1;" +
40-
"26=1;27=1;28=1;29=1;30=1;31=1;32=1;33=1;35=1;36=1;37=1;38=1;39=1;40=1;41=1;46=1;47=1;48=1;49=1;50=1");
41-
4238
assertThat(getMeasureAsInt(componentKey, "functions")).isEqualTo(3);
43-
44-
assertThat(getMeasure(componentKey, "executable_lines_data").getValue())
45-
.isEqualTo("32=1;36=1;37=1;38=1;40=1;49=1;22=1;23=1;25=1;26=1;27=1;29=1;30=1");
4639
}
4740
}

‎its/plugin/src/test/java/org/sonarsource/slang/NoSonarTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎its/plugin/src/test/java/org/sonarsource/slang/SonarLintTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎its/plugin/src/test/java/org/sonarsource/slang/TestBase.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎its/plugin/src/test/java/org/sonarsource/slang/TestReportTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎its/plugin/src/test/java/org/sonarsource/slang/Tests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎its/ruling/src/test/java/org/sonarsource/slang/SlangRulingTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/sonarpedia.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"languages": [
44
"GO"
55
],
6-
"latest-update": "2024-11-26T13:00:59.627691847Z",
6+
"latest-update": "2025-02-25T12:54:01.832512Z",
77
"options": {
88
"no-language-in-filenames": true,
99
"preserve-filenames": true

‎sonar-go-plugin/src/main/java/org/sonar/go/checks/CodeAfterJumpGoCheck.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/checks/DuplicateBranchGoCheck.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/checks/NativeKinds.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/checks/OneStatementPerLineGoCheck.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/checks/package-info.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/converter/ExternalProcessStreamConsumer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/converter/GoConverter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/converter/package-info.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/coverage/GoCoverSensor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/coverage/GoPathContext.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/coverage/package-info.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/externalreport/AbstractReportSensor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/externalreport/ExternalIssue.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/externalreport/ExternalKeyUtils.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/externalreport/GoLintReportSensor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/externalreport/GoMetaLinterReportSensor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/externalreport/GoVetReportSensor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/externalreport/GolangCILintReportSensor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/externalreport/package-info.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/plugin/GoCheckList.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/plugin/GoExclusionsFileFilter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/plugin/GoLanguage.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/plugin/GoPlugin.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/plugin/GoProfileDefinition.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/plugin/GoRulesDefinition.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/plugin/GoSensor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/plugin/InstanceScopeGoConverter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/plugin/package-info.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/testreport/GoTestSensor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/java/org/sonar/go/testreport/package-info.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
22
* SonarSource Go
3-
* Copyright (C) 2018-2024 SonarSource SA
3+
* Copyright (C) 2018-2025 SonarSource SA
44
* mailto:info AT sonarsource DOT com
55
*
66
* This program is free software; you can redistribute it and/or

‎sonar-go-plugin/src/main/resources/org/sonar/l10n/go/rules/go/S1135.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"type": "CODE_SMELL",
44
"code": {
55
"impacts": {
6-
"MAINTAINABILITY": "LOW"
6+
"MAINTAINABILITY": "INFO"
77
},
88
"attribute": "COMPLETE"
99
},

‎sonar-go-plugin/src/main/resources/org/sonar/l10n/go/rules/go/S1451.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
"func": "Constant\/Issue",
1313
"constantCost": "5min"
1414
},
15-
"tags": [],
15+
"tags": [
16+
"convention"
17+
],
1618
"defaultSeverity": "Blocker",
1719
"ruleSpecification": "RSPEC-1451",
1820
"sqKey": "S1451",

0 commit comments

Comments
 (0)