SONARPHP-772: fix parseInt exception (#558)

* check for too long values in exceptions

* simplify exceptions condition

Author: karim-ouerghemmi-sonarsource

php-checks/src/main/java/org/sonar/php/checks/UseOfOctalValueCheck.java

@@ -54,8 +54,9 @@ private void checkNumericValue(LiteralTree tree) {
   /**
    * This rule should not apply to values smaller than 8 and octal values having 3 digits,
    * since 3 digits octal values are often used as file permission masks.
+   * Also values like "03" should not raise an issue because they are used in dates.
    */
   private static boolean isException(String value) {
-    return value.length() == 4 || Integer.parseInt(value) < 8;
+    return value.length() == 4 || value.length() == 2;
   }
 }

php-checks/src/test/resources/checks/UseOfOctalValueCheck.php

@@ -15,6 +15,7 @@
 $a = "01234"; // Compliant
 $a = 0_1; // Compliant
 $a = 0_1234; // Noncompliant
+$a = 020000000000; // Noncompliant
 
 //--------------------------
 //  VariableDeclaration