SCANJLIB-246 Try adding test

Author: antoine-vinot-sonarsource

lib/src/main/java/org/sonarsource/scanner/lib/internal/facade/forked/JavaRunner.java

@@ -36,7 +36,7 @@
 public class JavaRunner {
   private static final Logger LOG = LoggerFactory.getLogger(JavaRunner.class);
 
-  private static final String JRE_VERSION_ERROR = "The version of the custom JRE provided to the SonarScanner using the 'sonar.scanner.javaExePath' parameter is incompatible " +
+  static final String JRE_VERSION_ERROR = "The version of the custom JRE provided to the SonarScanner using the 'sonar.scanner.javaExePath' parameter is incompatible " +
     "with your SonarQube target. You may need to upgrade the version of Java that executes the scanner. " +
     "Refer to https://docs.sonarsource.com/sonarqube-community-build/analyzing-source-code/scanners/scanner-environment/general-requirements/ for more details.";
 

lib/src/test/java/org/sonarsource/scanner/lib/internal/facade/forked/JavaRunnerTest.java

@@ -23,12 +23,15 @@
 import java.util.List;
 import java.util.concurrent.ConcurrentLinkedDeque;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.EnabledOnOs;
+import org.junit.jupiter.api.condition.OS;
 import org.junit.jupiter.api.extension.RegisterExtension;
 import org.slf4j.event.Level;
 import testutils.LogTester;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.sonarsource.scanner.lib.internal.facade.forked.JavaRunner.JRE_VERSION_ERROR;
 
 class JavaRunnerTest {
 
@@ -84,4 +87,24 @@ void execute_shouldReturnFalseWhenNonZeroExitCode() {
     assertThat(runner.execute(command, null, stdOut::add)).isFalse();
   }
 
+  @Test
+  @EnabledOnOs(OS.WINDOWS)
+  void execute_shouldLogUnsupportedClassVersionError_whenOsIsWindows() {
+    JavaRunner runner = new JavaRunner(Paths.get("cmd.exe"), JreCacheHit.DISABLED);
+    List<String> command = List.of("/c", "echo UnsupportedClassVersionError 1>&2");
+
+    assertThat(runner.execute(command, null, stdOut::add)).isTrue();
+    assertThat(logTester.logs(Level.ERROR)).contains(JRE_VERSION_ERROR);
+  }
+
+  @Test
+  @EnabledOnOs(OS.LINUX)
+  void execute_shouldLogUnsupportedClassVersionError_whenOsIsLinux() {
+    JavaRunner runner = new JavaRunner(Paths.get("sh"), JreCacheHit.DISABLED);
+    List<String> command = List.of("-c", " >&2 echo UnsupportedClassVersionError");
+
+    assertThat(runner.execute(command, null, stdOut::add)).isTrue();
+    assertThat(logTester.logs(Level.ERROR)).contains(JRE_VERSION_ERROR);
+  }
+
 }